← Back to issue list

lint: support the existence of 'venv'

View original Github issue

Metadata

Project
snapcraft
Number
#3941
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged after reviewer approval and passing CI. Adds 'venv' and '.venv' to .gitignore and configures codespell to skip these common virtual environment directories.

Suggested action:

No scores available.

Issue body

'venv' is a very common virtual-env name, so add it and '.venv' to gitignore and have codespell skip it. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after reviewer approval and passing CI. Adds 'venv' and '.venv' to .gitignore and configures codespell to skip these common virtual environment directories.
qwen3.6-35b-a3b-mtp-q6 Merged: added 'venv' and '.venv' to .gitignore and configured codespell to skip them, preventing false positives for the common virtual environment directory.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3936 lint: support the existence of 'venv' snapcraft closed Merged into main. Added 'venv' to .gitignore and codespell skip list to prevent linting errors for common virtual environment directories. Approved by one reviewer with passing CI checks.
95%
#35 lint: skip more commonly ignored files and directories with codespell starbase merged Merged an update to the codespell configuration that skips additional commonly ignored files and directories. Approved by a reviewer, passed CI checks, and applied with a minimal one-file change.
73%
#3028 static: add codespell excludes for .direnv snapcraft merged Merged a single-line update to exclude the .direnv directory from codespell checks. Approved by one reviewer and passed CI.
70%
#461 Add .venv removal to make clean starbase merged Merged. Added .venv to the make clean target in common.mk to enable full virtual environment recreation. Approved by three reviewers, passed CI checks, and resolves canonical/starbase#460.
70%
#4022 lint: ignore snapd-testing-tools, venv snapcraft merged Merged linter configuration updates to ignore venv, snapd-testing-tools, and cache directories, resolving local development failures. Approved by reviewers, passed CI, and integrated into main.
70%