← Back to issue list

feat(lint): lint the Github actions with actionlint

View original Github issue

Metadata

Project
starbase
Number
#470
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged; the same actionlint integration shipped via merged PR #473 (commit e385e9d), wiring the actionlint snap into starbase's default lint target.

Resolution: closed superseded

Reason: PR #470 was closed without merging; the identical 'feat(lint): lint the Github actions with actionlint' change was re-submitted as PR #473, which was merged into main as commit e385e9d (Makefile changes visible in history).

Evaluated by: mr-cal-bot

No scores available.

Issue body

This installs the snap of actionlint (https://github.com/rhysd/actionlint) and adds it as another default linter. Actionlint catches many common mistakes and has the advantage of running either shellcheck or pyflakes on scripts inside the actions. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged; the same actionlint integration shipped via merged PR #473 (commit e385e9d), wiring the actionlint snap into starbase's default lint target.
stealth/space-bunny-alpha — closed superseded PR #470 closed unmerged; the same actionlint integration landed through merged PR #473 in commit e385e9d.
qwen/qwen3.6-35b-a3b — — Closed without merging. The addition of actionlint for GitHub Actions linting was abandoned due to pending review and unresolved comments, despite all CI checks passing.
qwen3.6-35b-a3b-mtp-q6 — — Merged to integrate actionlint as a default linter for GitHub Actions workflows, enabling automated linting and script validation.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/starbase#473 (confidence 97%)

    Same title/scope, merged with two approvals and all CI green, landing as commit e385e9d

  • Likely Fixed By: e385e9d (confidence 95%)

    Merging commit that adds actionlint to the Makefile lint tooling

Related issues

Issue Project State Summary Similarity
#473 feat(lint): lint the Github actions with actionlint starbase merged Merged PR #473 in commit e385e9d, adding actionlint-based linting for GitHub Actions workflows to the shared build tooling.
88%
#450 fix(ci): resolve actionlint findings in snap and spread-test workflows imagecraft closed Actionlint fixes from #450 landed as commit f9425e0 and were carried into main by merged Starbase PR #449 (545f51a), despite #450 itself being closed unmerged.
77%
#2893 ci: fix actionlint findings ahead of Starbase merge charmcraft closed Closed unmerged; its actionlint fixes were superseded by merged PR charmcraft#2897 and Starbase merge charmcraft#2899.
74%
#6448 fix(lint): lint snaps in a build environment matching their base snapcraft closed Proposed base-aware lint environments for newer snaps, but PR #6448 was closed unmerged after two days without review; issue #6332 remains open.
71%