← Back to issue list

fix: harden 'make help' for shell portability

View original Github issue

Metadata

Project
starbase
Number
#542
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #542 as commit 3754b6a, hardening common.mk's help target for shell portability and fixing #538.

Resolution: closed resolved

Reason: PR #542 was merged with two approvals and all CI checks passing. Commit 3754b6a makes the help target portable across /bin/sh implementations and closed issue #538.

Evaluated by: mr-cal-bot

No scores available.

Issue body

I believe this fixes #538 --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #542 as commit 3754b6a, hardening common.mk's help target for shell portability and fixing #538.
stealth/space-bunny-alpha — closed resolved Merged with passing CI and two approvals; PR #542 fixes issue #538 by making the root Makefile's make help target portable to non-dash shells.
qwen/qwen3.6-35b-a3b — — Merged to harden make help for shell portability, resolving issue 538. Approved by two reviewers with passing CI. A reviewer requested changing the commit prefix from fix to build for clearer history tracking before final merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged after reviewer requested changing the commit prefix from fix to build. The change hardens the make help command for shell portability and resolves issue 538.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/starbase#538 (confidence 100%)

    Reported that make help failed; the issue was fixed by PR #542.

Related issues

Issue Project State Summary Similarity
#1105 fix: correct common.mk help target listing rockcraft merged Merged PR #1105 as commit 6ae769e9, preserving Makefile target names in common.mk help output and fixing #941.
75%
#538 bug: make help does not work starbase closed Fixed in merged PR #542 (commit 3754b6a), making the root make help target portable across /bin/sh implementations.
75%