← Back to issue list

fix(publish): support build-for 'all'

View original Github issue

Metadata

Project
starflow
Number
#45
Type
pull request
State
merged
Author
dariuszd21
Labels
Created
Updated
Closed

Current evaluation

Merged a fix to the publish step supporting build-for 'all'. The change prevents platform override when 'all' is defined and adds a fallback to locate architecture-specific remote-build logs. Approved by two reviewers.

Suggested action:

No scores available.

Issue body

Do not override `platforms` if "all" is defined. Fallback to reading any logfile if `${arch}`-including one cannot be found - for `all`, remote-build log has a suffix of the architecture it was build on, not `all`

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix to the publish step supporting build-for 'all'. The change prevents platform override when 'all' is defined and adds a fallback to locate architecture-specific remote-build logs. Approved by two reviewers.
qwen3.6-35b-a3b-mtp-q6 Merged a fix to support build-for 'all' in the publish workflow. Platforms are preserved when 'all' is specified, and log reading falls back to architecture-specific files instead of requiring an exact 'all' suffix.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#365 feat: accept build-for: [all] in platforms craft-application merged Merged via rebase after approval and passing CI. Enables build-for: [all] in platform definitions, restricting other platforms when used. Resolves #360.
72%
#687 fix(commands/lifecycle): Pass the correct platform and build-for craft-application merged Merged fix correcting platform and build-for parameter passing in lifecycle commands, resolving a "Multiple builds match the current platform" error. Approved by two reviewers and passed CI.
70%