← Back to issue list

build: do not create metafiles when using reactive

View original Github issue

Metadata

Project
charmcraft
Number
#1151
Type
pull request
State
merged
Author
syu-w
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1151 as commit 35adadf4, stopping Charmcraft from generating metafiles for reactive builds and preserving Reactive's own format; fixes #1150.

Resolution: closed resolved

Reason: PR #1151 was approved and merged as commit 35adadf4. The #1150 reporter confirmed correct metadata, config, and actions in version 2.3.0.post17+git35adadf.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The reactive framework uses an incompatible variant that creates its own files. The format defined by charmcraft cannot be used. Fix: https://github.com/canonical/charmcraft/issues/1150

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1151 as commit 35adadf4, stopping Charmcraft from generating metafiles for reactive builds and preserving Reactive's own format; fixes #1150.
stealth/space-bunny-alpha — closed resolved Merged PR #1151 (commit 35adadf4) stops Charmcraft from generating metafiles for reactive builds, preserving reactive's own file format and fixing #1150.
qwen/qwen3.6-35b-a3b — — Merged changes preventing metafile creation for the reactive framework due to charmcraft format incompatibility. Resolves issue #1150. Approved by one reviewer, passed CI, and modified one file (+6/-3).
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix to prevent metafile creation when using the reactive framework. The reactive variant generates incompatible files that conflict with charmcraft's format, resolving issue #1150.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1150 (confidence 100%)

    Reactive build regression explicitly fixed by this PR.

  • Caused By: canonical/charmcraft#1126 (confidence 85%)

    Issue #1150 identified this earlier PR as the likely source of the incompatible metadata generation.

Related issues

Issue Project State Summary Similarity
#1666 fix: only keep metadata.yaml for reactive charms charmcraft merged Merged #1666 (b2b127e6), retaining metadata.yaml only for reactive charms so non-reactive repacks no longer carry stale integration metadata; fixes #1654.
72%
#2502 fix: add missing build metadata in reactive charm artifacts charmcraft open Adds .build.manifest preservation and charmtool_version to manifest.yaml for reactive charms. Under active review with 4 unresolved comments; most CI checks pending.
71%
#2245 fix(reactive): don't overwrite config.yaml from a reactive charm charmcraft merged Merged PR #2245 (commit aa28f0dc, CRAFT-4206) stops the package service from overwriting a config.yaml generated by a reactive charm, fixing #2194.
71%