← Back to issue list

fix(reactive): don't overwrite config.yaml from a reactive charm

View original Github issue

Metadata

Project
charmcraft
Number
#2245
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged following approval by three reviewers. Resolves issue #2194 and CRAFT-4206 by preventing reactive charms from overwriting config.yaml. Changes affect three files with minor code adjustments.

Suggested action: —

No scores available.

Issue body

Fixes #2194 CRAFT-4206

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged following approval by three reviewers. Resolves issue #2194 and CRAFT-4206 by preventing reactive charms from overwriting config.yaml. Changes affect three files with minor code adjustments.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix preventing config.yaml overwrites in reactive charms. Resolves issue #2194 and CRAFT-4206 by preserving existing configuration files during charm operations.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix preventing reactive charms from overwriting config.yaml, resolving issue #2194 and CRAFT-4206. Configuration files are now preserved during charm operations.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1829 fix(reactive): don't overwrite actions.yaml for reactive charms charmcraft merged Merged to fix issue #1816 by preventing the overwriting of actions.yaml for reactive charms. Approved by two reviewers, the change updates two files (+29/-5 lines) and resolves CRAFT-3247.
87%
#1666 fix: only keep metadata.yaml for reactive charms charmcraft merged Merged to fix issue #1654 by restricting metadata.yaml retention to reactive charms only. Approved by two reviewers, passed CI, and modified six files (+101/-5).
80%
#1524 fix(package): don't write a metadata.yaml if it already exists. charmcraft merged Merged a fix preventing overwrites of existing metadata.yaml files. Approved by two reviewers, this change enables reactive charm support in destructive mode as a partial resolution for issue #1488.
75%
#1151 build: do not create metafiles when using reactive charmcraft merged Merged changes preventing metafile creation for the reactive framework due to charmcraft format incompatibility. Resolves issue #1150. Approved by one reviewer, passed CI, and modified one file (+6/-3).
73%