Store: More heavily utilise craft-store
Metadata
Current evaluation
Closed without resolution, likely abandoned or superseded. The proposal to replace charmcraft's custom store client with craft-store to eliminate redundant code was never implemented or linked to a pull request.
Suggested action: —
No scores available.
Issue body
### What needs to get done
The current store commands make a lot of direct queries using a custom Client's `request_urlpath_json` and `request_urlpath_text`. Charmcraft should be a generic store client, so anything that uses the store should utilise the clients in `craft-store`. https://github.com/canonical/craft-store/blob/main/craft_store/base_client.py
We should be able to entirely eliminate the store clients (https://github.com/canonical/charmcraft/blob/craft-app/new-entrypoint/charmcraft/commands/store/client.py) by using craft-store instead. Features that don't currently exist in craft-store should be added in a generic manner so all craft apps can use them.
### Why it needs to get done
We have significant amounts of redundant code between craft-store and charmcraft.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without resolution, likely abandoned or superseded. The proposal to replace charmcraft's custom store client with craft-store to eliminate redundant code was never implemented or linked to a pull request. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. The initiative to replace charmcraft's custom store client with craft-store was abandoned due to inactivity. No pull requests or resolution details were provided. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. No follow-up pull requests or commits reference replacing charmcraft's custom store clients with craft-store. The request appears abandoned due to prolonged inactivity and zero comments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without implementation or linked pull requests. The request to replace charmcraft's custom store client with craft-store was abandoned or superseded by later architectural changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without implementation, likely abandoned due to inactivity. The proposed migration from charmcraft's custom store client to craft-store to eliminate redundant code was never executed. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3684 legacy storeapi: use craft-store | snapcraft | closed | Superseded in favor of PR #3692. The PR proposed replacing legacy storeapi http_clients with craft-store and adapting related code. It was closed without review or merge after the maintainer directed all changes to the alternative PR. | |
| #565 store: replace implementation with craft-store (CRAFT-491) | charmcraft | merged | Merged the replacement of the store implementation with craft-store (CRAFT-491). Approved by one reviewer, the change reduced code by 296 lines across 10 files and was signed off by maintainer sergiusens. |