← Back to issue list

store: replace implementation with craft-store (CRAFT-491)

View original Github issue

Metadata

Project
charmcraft
Number
#565
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged #565 into main, replacing Charmcraft's store implementation with craft-store for CRAFT-491 (merge commit 70ba8e28).

Resolution: closed resolved

Reason: PR #565 was approved and merged into main as commit 70ba8e28, completing the CRAFT-491 store migration.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #565 into main, replacing Charmcraft's store implementation with craft-store for CRAFT-491 (merge commit 70ba8e28).
stealth/space-bunny-alpha — closed resolved Merged #565, replacing Charmcraft’s store implementation with craft-store for CRAFT-491 in merge commit 70ba8e28.
stealth/space-bunny-alpha — closed resolved Merged canonical/charmcraft#565, replacing the store implementation with craft-store for CRAFT-491.
qwen/qwen3.6-35b-a3b — — Merged the replacement of the store implementation with craft-store (CRAFT-491). Approved by one reviewer, the change reduced code by 296 lines across 10 files and was signed off by maintainer sergiusens.
qwen3.6-35b-a3b-mtp-q6 — — Merged the update replacing the store implementation with craft-store, resolving CRAFT-491. Maintainer sergiusens integrated the change directly without additional review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3684 legacy storeapi: use craft-store snapcraft closed Closed in favor of #3692, which merged the legacy storeapi migration to craft-store as 15b55daa8 (merge 5a850ca04).
76%
#24 release: 1.1.0 (CRAFT-645) craft-store merged Merged craft-store 1.1.0 for CRAFT-645 via PR #24 in merge commit 562b51f.
75%
#57 release 2.1.1 craft-store merged Merged craft-store 2.1.1 in PR #57 via release commit bd6bb4e and merge commit 33de146.
71%
#48 release: 2.0.1 craft-store merged Merged craft-store 2.0.1 via PR #48; merge commit fb75d74 brought in release commit 53f880d.
71%
#956 Updated the Craft Store version, fixing a test fake structure. charmcraft merged Merged PR #956 via 431c53bc, updating the Craft Store dependency and correcting the affected test fake structure.
71%
#67 release 2.2.1 craft-store merged Merged craft-store 2.2.1 in PR #67 via commit ee98080.
71%
#667 craft store: update to 2.0.0 (CRAFT-773) charmcraft merged Merged PR #667 by sergiusens bumped charmcraft to craft-store 2.0.0 (CRAFT-773, commit 7d893cdc): new StoreClient init params, NotLoggedIn -> CredentialsUnavailable rename, better missing-keyring handling.
71%
#1459 feat: basic store service charmcraft merged Merged in canonical/charmcraft#1459 (5dcad2af), adding a craft-application-style StoreService for store commands with Charmcraft-specific defaults.
70%
#3692 legacy storeapi: use craft-store snapcraft merged PR #3692 merged into snapcraft/7.0 (merge 5a850ca04, commit 15b55daa8), swapping legacy storeapi's http_clients implementation for craft-store, dropping obsolete tests, adapting callers to API changes, and removing needless logout calls.
70%
#73 Support cases of Store not respecting the API charmcraft closed Store API resilience moved to craft-store when Charmcraft replaced its Store implementation in commit 35bb1cf4 via #565; the issue was later closed as handled there.
70%