← Back to issue list

store: replace implementation with craft-store (CRAFT-491)

View original Github issue

Metadata

Project
charmcraft
Number
#565
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged the replacement of the store implementation with craft-store (CRAFT-491). Approved by one reviewer, the change reduced code by 296 lines across 10 files and was signed off by maintainer sergiusens.

Suggested action:

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the replacement of the store implementation with craft-store (CRAFT-491). Approved by one reviewer, the change reduced code by 296 lines across 10 files and was signed off by maintainer sergiusens.
qwen3.6-35b-a3b-mtp-q6 Merged the update replacing the store implementation with craft-store, resolving CRAFT-491. Maintainer sergiusens integrated the change directly without additional review comments.
qwen3.6-35b-a3b-mtp-q6 Merged to replace the store implementation with craft-store, resolving CRAFT-491. The maintainer integrated the change directly without additional comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3692 legacy storeapi: use craft-store snapcraft merged Merged PR replaces the legacy storeapi HTTP client with craft-store, removes obsolete tests and logout calls, and adapts the codebase to craft-store API changes. Approved and passed CI.
74%
#3684 legacy storeapi: use craft-store snapcraft closed Superseded in favor of PR #3692. The PR proposed replacing legacy storeapi http_clients with craft-store and adapting related code. It was closed without review or merge after the maintainer directed all changes to the alternative PR.
73%
#956 Updated the Craft Store version, fixing a test fake structure. charmcraft merged Merged after approval. Updated the Craft Store version and fixed a test fake structure. The commit modifies three files with eight additions and three deletions.
72%
#671 snap: update craft-store to 2.0.1 charmcraft merged The craft-store update to 2.0.1 was successfully merged after receiving reviewer approval and passing CI checks. The minor two-file change was integrated without further modifications.
72%
#1155 Store: More heavily utilise craft-store charmcraft closed Closed without resolution, likely abandoned or superseded. The proposal to replace charmcraft's custom store client with craft-store to eliminate redundant code was never implemented or linked to a pull request.
72%
#574 requirements: update craft-store and others charmcraft merged Merged dependency updates for craft-store and other packages. Approved by one reviewer with zero unresolved comments. Modified four files, adding and removing 23 lines each.
70%