legacy storeapi: use craft-store
Metadata
Current evaluation
Superseded in favor of PR #3692. The PR proposed replacing legacy storeapi http_clients with craft-store and adapting related code. It was closed without review or merge after the maintainer directed all changes to the alternative PR.
Suggested action: —
No scores available.
Issue body
- Replace the http_clients implementation in storeapi with craft-store.
- Remove no longer necessary tests.
- Adapt the code base to the slight API changes (with consideration of
- being entirely replaced as commands migrate out of legacy).
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Superseded in favor of PR #3692. The PR proposed replacing legacy storeapi http_clients with craft-store and adapting related code. It was closed without review or merge after the maintainer directed all changes to the alternative PR. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded in favor of pull request #3692. The legacy storeapi replacement with craft-store was implemented through the alternative PR instead. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded in favor of PR #3692. The legacy storeapi http_clients replacement with craft-store was abandoned to avoid duplication. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3692 legacy storeapi: use craft-store | snapcraft | merged | Merged PR replaces the legacy storeapi HTTP client with craft-store, removes obsolete tests and logout calls, and adapts the codebase to craft-store API changes. Approved and passed CI. | |
| #1155 Store: More heavily utilise craft-store | charmcraft | closed | Closed without resolution, likely abandoned or superseded. The proposal to replace charmcraft's custom store client with craft-store to eliminate redundant code was never implemented or linked to a pull request. | |
| #565 store: replace implementation with craft-store (CRAFT-491) | charmcraft | merged | Merged the replacement of the store implementation with craft-store (CRAFT-491). Approved by one reviewer, the change reduced code by 296 lines across 10 files and was signed off by maintainer sergiusens. |