legacy storeapi: use craft-store
Metadata
Current evaluation
Closed in favor of #3692, which merged the legacy storeapi migration to craft-store as 15b55daa8 (merge 5a850ca04).
Resolution: closed superseded
Reason: Maintainer sergiusens closed #3684 after stating "Favoring #3692." PR #3692 was merged via 5a850ca04, implementing the migration in commit 15b55daa8.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- Replace the http_clients implementation in storeapi with craft-store.
- Remove no longer necessary tests.
- Adapt the code base to the slight API changes (with consideration of
- being entirely replaced as commands migrate out of legacy).
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed in favor of #3692, which merged the legacy storeapi migration to craft-store as 15b55daa8 (merge 5a850ca04). | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by canonical/snapcraft#3692, which merged as commit 15b55daa8 and migrated legacy storeapi to craft-store. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed in favor of #3692, which replaced legacy storeapi's HTTP client with craft-store; #3692 merged via commit 15b55daa8 (merge 5a850ca04). | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged in favor of #3692, which replaced legacy storeapi’s HTTP client with craft-store, removed obsolete tests and logout calls, and adapted callers (commit 15b55daa8). | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged in favor of #3692, which replaced legacy storeapi's HTTP client with craft-store and removed obsolete tests and logout calls. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by PR #3692, which migrated legacy storeapi to craft-store and was merged in commit 15b55daa8. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded in favor of PR #3692. The PR proposed replacing legacy storeapi http_clients with craft-store and adapting related code. It was closed without review or merge after the maintainer directed all changes to the alternative PR. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded in favor of pull request #3692. The legacy storeapi replacement with craft-store was implemented through the alternative PR instead. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#3692
(confidence 100%)
Replacement PR merged the craft-store migration.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3692 legacy storeapi: use craft-store | snapcraft | merged | PR #3692 merged into snapcraft/7.0 (merge 5a850ca04, commit 15b55daa8), swapping legacy storeapi's http_clients implementation for craft-store, dropping obsolete tests, adapting callers to API changes, and removing needless logout calls. | |
| #565 store: replace implementation with craft-store (CRAFT-491) | charmcraft | merged | Merged #565 into main, replacing Charmcraft's store implementation with craft-store for CRAFT-491 (merge commit 70ba8e28). | |
| #3794 store: full support for legacy login | snapcraft | merged | Merged PR #3794 via commit 86193a7b4 (7194ef18d), restoring legacy-login compatibility by using existing Snapcraft credentials to build craft-store authorization headers. | |
| #73 Support cases of Store not respecting the API | charmcraft | closed | Store API resilience moved to craft-store when Charmcraft replaced its Store implementation in commit 35bb1cf4 via #565; the issue was later closed as handled there. | |
| #3562 storeapi: improve candid interaction errors (CRAFT-135) | snapcraft | merged | Merged #3562 via e2640b1bd (merge 54781044a), adding distinct Store API errors and messages for token-related candid interactions. | |
| #24 release: 1.1.0 (CRAFT-645) | craft-store | merged | Merged craft-store 1.1.0 for CRAFT-645 via PR #24 in merge commit 562b51f. | |
| #1284 Migrate store commands to craft-application | charmcraft | closed | Store commands were migrated to craft-application in merged PR #1358 (commit 5cb01186); commit 9da46c37 later removed the unused legacy implementations. |