← Back to issue list

chore(deps): update dependency urllib3 to v1.26.17 [security]

View original Github issue

Metadata

Project
charmcraft
Number
#1308
Type
pull request
State
merged
Author
renovate[bot]
Labels
—
Created
Updated
Closed

Current evaluation

Renovate security bump of urllib3 1.26.16 -> 1.26.17 (CVE-2023-43804 Cookie header leak on redirect) merged into main as commit 51323d0f, changing2 dependency pin files.

Resolution: closed resolved

Reason: The PR was approved by 2 reviewers and merged into main as commit 51323d0f ("chore(deps): update dependency urllib3 to v1.26.17 [security]"), confirmed by a pickaxe search for 'urllib3==1.26.17' hitting that commit in the repository history. It patched CVE-2023-43804.

Evaluated by: mr-cal-bot

No scores available.

Issue body

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [urllib3](https://togithub.com/urllib3/urllib3) ([changelog](https://togithub.com/urllib3/urllib3/blob/main/CHANGES.rst)) | `==1.26.16` -> `==1.26.17` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/urllib3/1.26.17?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/urllib3/1.26.17?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/urllib3/1.26.16/1.26.17?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/urllib3/1.26.16/1.26.17?slim=true)](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2023-43804](https://togithub.com/urllib3/urllib3/security/advisories/GHSA-v845-jxx5-vc9f) urllib3 doesn't treat the `Cookie` HTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify a `Cookie` header and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly. Users **must** handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the `Cookie` header, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach. ## Affected usages We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited: * Using an affected version of urllib3 (patched in v1.26.17 and v2.0.6) * Using the `Cookie` header on requests, which is mostly typical for impersonating a browser. * Not disabling HTTP redirects * Either not using HTTPS or for the origin server to redirect to a malicious origin. ## Remediation * Upgrading to at least urllib3 v1.26.17 or v2.0.6 * Disabling HTTP redirects using `redirects=False` when sending requests. * Not using the `Cookie` header. --- ### Release Notes <details> <summary>urllib3/urllib3 (urllib3)</summary> ### [`v1.26.17`](https://togithub.com/urllib3/urllib3/compare/1.26.16...1.26.17) [Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.16...1.26.17) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" in timezone Etc/UTC, Automerge - "before 07:00" in timezone Etc/UTC. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/charmcraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Renovate security bump of urllib3 1.26.16 -> 1.26.17 (CVE-2023-43804 Cookie header leak on redirect) merged into main as commit 51323d0f, changing2 dependency pin files.
stealth/space-bunny-alpha — closed resolved Merged in #1308 (commit 51323d0f), upgrading urllib3 from 1.26.16 to 1.26.17 to address CVE-2023-43804 and prevent Cookie-header leakage across redirects.
qwen/qwen3.6-35b-a3b — — Merged automated dependency update upgrading urllib3 from v1.26.16 to v1.26.17 to patch CVE-2023-43804, preventing Cookie header leakage via HTTP redirects. Approved by two reviewers, passed CI, and auto-merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged automated dependency update upgrading urllib3 from v1.26.16 to v1.26.17 to patch CVE-2023-43804, preventing Cookie header leakage during HTTP redirects. Applied via Renovate automerge.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/charmcraft#1394 (confidence 55%)

    Follow-up #1394 (commit b3ab8f39) froze types-requests for urllib3 compatibility; the urllib3 pin was later bumped again to 1.26.18 in commit 25d6160d.

  • Related To: canonical/charmcraft#1309 (confidence 15%)

    Nearby PR number only; unrelated pydantic.validator style change, listed for completeness of PR numbering context.

Related issues

Issue Project State Summary Similarity
#1337 chore(deps): update dependency urllib3 to v1.26.18 [security] charmcraft merged Merged PR #1337 as 25d6160d, upgrading urllib3 from 1.26.17 to 1.26.18 to remediate CVE-2023-45803.
92%
#4860 chore(deps): update dependency urllib3 to v1.26.19 [security] - autoclosed snapcraft closed Autoclosed: duplicate of merged Dependabot PR #4859 (commit 60d370276), which already bumped urllib3 1.26.18 -> 1.26.19 (CVE-2024-37891) in main.
90%
#369 chore(deps): update dependency urllib3 to v2 craft-providers closed Renovate's urllib3 v2 update was closed unmerged because #264 pinned urllib3 to v1 pending msabramo/requests-unixsocket#69.
84%
#4388 build(deps): bump urllib3 from 1.26.15 to 1.26.17 snapcraft merged Merged PR #4388 upgraded urllib3 from 1.26.15 to 1.26.17 in commit 8b7202506, adding redirect Cookie stripping and pool thread-safety fixes.
78%
#195 build(deps): update dependency urllib3 to v1.26.20 (main) starflow closed Automated dependency update upgrading urllib3 to v1.26.20. Closed and merged into main by Renovate.
78%
#339 chore(deps): update bugfixes rockcraft merged Renovate dependency bump PR merged as commit b72aed86 (urllib3 1.26.13->1.26.16, PyYAML 6.0->6.0.1, MarkupSafe, click, codespell, etc.) after the Pyright lint blocker was resolved in PR #342.
76%
#4859 build(deps): bump urllib3 from 1.26.18 to 1.26.19 snapcraft merged Dependabot PR merged, bumping urllib3 1.26.18 to 1.26.19 in the main requirements (commit 60d370276, PR #4859); approved by 2 reviewers with no unresolved comments.
76%
#3532 build(deps): bump urllib3 from 1.26.4 to 1.26.5 snapcraft merged Merged PR #3532 via commit 6ddfcad68, updating urllib3 from 1.26.4 to 1.26.5 in two files.
75%
#1307 build(deps): bump urllib3 from 1.26.16 to 1.26.17 charmcraft closed Dependabot closed #1307 unmerged as obsolete: the identical urllib3 1.26.16→1.26.17 security bump had already landed via #1308 (commit 51323d0f).
74%
#4404 build(deps): bump urllib3 from 1.26.17 to 1.26.18 snapcraft merged Dependabot PR #4404 bumping urllib3 1.26.17→1.26.18 (GHSA-g4mx-q9vg-27p4 HTTP 303 redirect fix) was approved by 2 reviewers and merged into main as commit bbd0a4ecd; sibling PR #4405 did the same for docs/.sphinx.
74%