← Back to issue list

chore(deps): update dependency urllib3 to v1.26.17 [security]

View original Github issue

Metadata

Project
charmcraft
Number
#1308
Type
pull request
State
merged
Author
renovate[bot]
Labels
Created
Updated
Closed

Current evaluation

Merged automated dependency update upgrading urllib3 from v1.26.16 to v1.26.17 to patch CVE-2023-43804, preventing Cookie header leakage via HTTP redirects. Approved by two reviewers, passed CI, and auto-merged.

Suggested action:

No scores available.

Issue body

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [urllib3](https://togithub.com/urllib3/urllib3) ([changelog](https://togithub.com/urllib3/urllib3/blob/main/CHANGES.rst)) | `==1.26.16` -> `==1.26.17` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/urllib3/1.26.17?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/urllib3/1.26.17?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/urllib3/1.26.16/1.26.17?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/urllib3/1.26.16/1.26.17?slim=true)](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2023-43804](https://togithub.com/urllib3/urllib3/security/advisories/GHSA-v845-jxx5-vc9f) urllib3 doesn't treat the `Cookie` HTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify a `Cookie` header and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly. Users **must** handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the `Cookie` header, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach. ## Affected usages We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited: * Using an affected version of urllib3 (patched in v1.26.17 and v2.0.6) * Using the `Cookie` header on requests, which is mostly typical for impersonating a browser. * Not disabling HTTP redirects * Either not using HTTPS or for the origin server to redirect to a malicious origin. ## Remediation * Upgrading to at least urllib3 v1.26.17 or v2.0.6 * Disabling HTTP redirects using `redirects=False` when sending requests. * Not using the `Cookie` header. --- ### Release Notes <details> <summary>urllib3/urllib3 (urllib3)</summary> ### [`v1.26.17`](https://togithub.com/urllib3/urllib3/compare/1.26.16...1.26.17) [Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.16...1.26.17) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" in timezone Etc/UTC, Automerge - "before 07:00" in timezone Etc/UTC. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/charmcraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged automated dependency update upgrading urllib3 from v1.26.16 to v1.26.17 to patch CVE-2023-43804, preventing Cookie header leakage via HTTP redirects. Approved by two reviewers, passed CI, and auto-merged.
qwen3.6-35b-a3b-mtp-q6 Merged automated dependency update upgrading urllib3 from v1.26.16 to v1.26.17 to patch CVE-2023-43804, preventing Cookie header leakage during HTTP redirects. Applied via Renovate automerge.
qwen3.6-35b-a3b-mtp-q6 Merged security patch updating urllib3 from 1.26.16 to 1.26.17 to resolve CVE-2023-43804, which prevents Cookie header leakage during HTTP redirects. Applied automatically via Renovate bot.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1337 chore(deps): update dependency urllib3 to v1.26.18 [security] charmcraft merged Merged automated update upgrading urllib3 from 1.26.17 to 1.26.18 to patch CVE-2023-45803, fixing HTTP request body leakage on 303 redirects. Approved and merged after passing CI checks.
95%
#4860 chore(deps): update dependency urllib3 to v1.26.19 [security] - autoclosed snapcraft closed The urllib3 security update to v1.26.19 was autoclosed by Renovate due to a branch head mismatch. The dependency change was not merged and the automated pull request was automatically closed.
87%
#4859 build(deps): bump urllib3 from 1.26.18 to 1.26.19 snapcraft merged Automated dependency update for urllib3 from 1.26.18 to 1.26.19 was approved, passed CI checks, and successfully merged.
81%
#4404 build(deps): bump urllib3 from 1.26.17 to 1.26.18 snapcraft merged Merged a Dependabot update bumping urllib3 from 1.26.17 to 1.26.18. Approved by two reviewers and passing CI, the branch was recreated to resolve a rebase conflict before final merge. The update improves HTTP 303 redirect handling.
78%
#363 build(deps): bump urllib3 from 1.26.4 to 1.26.5 charmcraft merged Merged Dependabot update bumping urllib3 from 1.26.4 to 1.26.5. The release fixes Python 3.10 deprecation warnings, updates vendored six, and optimizes URL parsing. Approved by two reviewers and passed CI checks prior to merge.
78%
#4388 build(deps): bump urllib3 from 1.26.15 to 1.26.17 snapcraft merged Merged Dependabot PR bumping urllib3 from 1.26.15 to 1.26.17. Update applies security patch GHSA-v845-jxx5-vc9f and fixes a PoolManager thread-safety issue. Approved by two reviewers, passed CI, and maintained coverage.
77%
#3532 build(deps): bump urllib3 from 1.26.4 to 1.26.5 snapcraft merged Merged an automated Dependabot update bumping urllib3 from 1.26.4 to 1.26.5. The change was approved, passed CI checks, and updated two files without impacting test coverage.
77%
#1430 build: update urllib3 craft-parts merged Merged update to the urllib3 dependency to resolve an OSV security vulnerability. Approved by two reviewers and passed CI checks. Modified one file with 27 additions and 5 deletions.
76%
#4405 build(deps): bump urllib3 from 1.26.17 to 1.26.18 in /docs/.sphinx snapcraft merged Dependabot PR bumping urllib3 from 1.26.17 to 1.26.18 in /docs/.sphinx was approved, passed CI, and merged. The update applies a security fix for HTTP 303 redirect handling.
76%
#5930 build: bump urllib3 snapcraft merged Merged a dependency update bumping urllib3 to resolve an OSV vulnerability. Approved by two reviewers and integrated after passing CI checks.
75%