← Back to issue list

chore(deps): update dependency urllib3 to v1.26.18 [security]

View original Github issue

Metadata

Project
charmcraft
Number
#1337
Type
pull request
State
merged
Author
renovate[bot]
Labels
Created
Updated
Closed

Current evaluation

Merged automated update upgrading urllib3 from 1.26.17 to 1.26.18 to patch CVE-2023-45803, fixing HTTP request body leakage on 303 redirects. Approved and merged after passing CI checks.

Suggested action:

No scores available.

Issue body

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [urllib3](https://togithub.com/urllib3/urllib3) ([changelog](https://togithub.com/urllib3/urllib3/blob/main/CHANGES.rst)) | `==1.26.17` -> `==1.26.18` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/urllib3/1.26.18?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/urllib3/1.26.18?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/urllib3/1.26.17/1.26.18?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/urllib3/1.26.17/1.26.18?slim=true)](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2023-45803](https://togithub.com/urllib3/urllib3/security/advisories/GHSA-g4mx-q9vg-27p4) urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like `POST`) to `GET` as is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers. From [RFC 9110 Section 9.3.1](https://www.rfc-editor.org/rfc/rfc9110.html#name-get): > A client SHOULD NOT generate content in a GET request unless it is made directly to an origin server that has previously indicated, in or out of band, that such a request has a purpose and will be adequately supported. ## Affected usages Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable. Both of the following conditions must be true to be affected by this vulnerability: * If you're using urllib3 and submitting sensitive information in the HTTP request body (such as form data or JSON) * The origin service is compromised and starts redirecting using 303 to a malicious peer or the redirected-to service becomes compromised. ## Remediation You can remediate this vulnerability with any of the following steps: * Upgrade to a patched version of urllib3 (v1.26.18 or v2.0.7) * Disable redirects for services that you aren't expecting to respond with redirects with `redirects=False`. * Disable automatic redirects with `redirects=False` and handle 303 redirects manually by stripping the HTTP request body. --- ### Release Notes <details> <summary>urllib3/urllib3 (urllib3)</summary> ### [`v1.26.18`](https://togithub.com/urllib3/urllib3/releases/tag/1.26.18) [Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.17...1.26.18) - Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses. (GHSA-g4mx-q9vg-27p4) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" in timezone Etc/UTC, Automerge - "before 07:00" in timezone Etc/UTC. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/charmcraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged automated update upgrading urllib3 from 1.26.17 to 1.26.18 to patch CVE-2023-45803, fixing HTTP request body leakage on 303 redirects. Approved and merged after passing CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged automated dependency update upgrading urllib3 from 1.26.17 to 1.26.18 to patch CVE-2023-45803, addressing an HTTP 303 redirect body leakage vulnerability. Applied via Renovate bot automerge.
qwen3.6-35b-a3b-mtp-q6 Merged automated dependency update upgrading urllib3 from v1.26.17 to v1.26.18 to patch CVE-2023-45803, preventing HTTP request body leakage during 303 redirects. Applied via Renovate automerge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1308 chore(deps): update dependency urllib3 to v1.26.17 [security] charmcraft merged Merged automated dependency update upgrading urllib3 from v1.26.16 to v1.26.17 to patch CVE-2023-43804, preventing Cookie header leakage via HTTP redirects. Approved by two reviewers, passed CI, and auto-merged.
95%
#4860 chore(deps): update dependency urllib3 to v1.26.19 [security] - autoclosed snapcraft closed The urllib3 security update to v1.26.19 was autoclosed by Renovate due to a branch head mismatch. The dependency change was not merged and the automated pull request was automatically closed.
87%
#4859 build(deps): bump urllib3 from 1.26.18 to 1.26.19 snapcraft merged Automated dependency update for urllib3 from 1.26.18 to 1.26.19 was approved, passed CI checks, and successfully merged.
81%
#4404 build(deps): bump urllib3 from 1.26.17 to 1.26.18 snapcraft merged Merged a Dependabot update bumping urllib3 from 1.26.17 to 1.26.18. Approved by two reviewers and passing CI, the branch was recreated to resolve a rebase conflict before final merge. The update improves HTTP 303 redirect handling.
80%
#4405 build(deps): bump urllib3 from 1.26.17 to 1.26.18 in /docs/.sphinx snapcraft merged Dependabot PR bumping urllib3 from 1.26.17 to 1.26.18 in /docs/.sphinx was approved, passed CI, and merged. The update applies a security fix for HTTP 303 redirect handling.
79%
#3532 build(deps): bump urllib3 from 1.26.4 to 1.26.5 snapcraft merged Merged an automated Dependabot update bumping urllib3 from 1.26.4 to 1.26.5. The change was approved, passed CI checks, and updated two files without impacting test coverage.
77%
#363 build(deps): bump urllib3 from 1.26.4 to 1.26.5 charmcraft merged Merged Dependabot update bumping urllib3 from 1.26.4 to 1.26.5. The release fixes Python 3.10 deprecation warnings, updates vendored six, and optimizes URL parsing. Approved by two reviewers and passed CI checks prior to merge.
77%
#339 chore(deps): update bugfixes rockcraft merged Merged automated patch updates for twelve Python dependencies, including urllib3, PyYAML, and click. The change passed CI, received two approvals, and was merged after a maintainer confirmed a related linting fix.
77%
#4388 build(deps): bump urllib3 from 1.26.15 to 1.26.17 snapcraft merged Merged Dependabot PR bumping urllib3 from 1.26.15 to 1.26.17. Update applies security patch GHSA-v845-jxx5-vc9f and fixes a PoolManager thread-safety issue. Approved by two reviewers, passed CI, and maintained coverage.
77%
#386 chore(deps): update dependency types-requests to v2.31.0.10 rockcraft closed Closed without merging due to a dependency conflict. A maintainer noted the update requires an incompatible urllib3 version. Renovate will ignore this specific update.
77%