← Back to issue list

Style: Enable mypy checking in all packages

View original Github issue

Metadata

Project
charmcraft
Number
#1316
Type
issue
State
closed
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Superseded. The project switched to the ty type checker, making the requested package-wide mypy configuration changes unnecessary.

Suggested action:

No scores available.

Issue body

### What needs to get done Remove the overrides section that ignores entire charmcraft modules. This could be multiple PRs as we're able to enable specific module typing ### Why it needs to get done Using mypy helps catch common bugs

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Superseded. The project switched to the ty type checker, making the requested package-wide mypy configuration changes unnecessary.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 40
Confidence: 85
Support Request: 5
close stale Enable mypy type checking across all packages by removing current ignore overrides. Open for over 2.5 years with zero comments and no maintainer engagement, awaiting triage or closure due to inactivity.
qwen3.6-35b-a3b-mtp-q6
Staleness: 90
Complexity: 45
Confidence: 75
Support Request: 5
close stale Enable mypy type checking across all packages by removing current ignore overrides. Currently inactive for nearly three years with no assignee, labels, or discussion.
qwen3.6-35b-a3b-mtp-q6
Staleness: 75
Complexity: 40
Confidence: 65
Support Request: 5
needs triage Enable mypy type checking across all packages by removing module-level ignore overrides. Open, inactive for 304 days, with zero comments. Needs triage and assignment to implement module-by-module typing.

Update history

Date Change
closed

Related issues

Issue Project State Summary Similarity
#1314 Type checking: enable stricter mypy rules charmcraft closed Superseded by a switch to the ty type checker. The request to enable stricter mypy rules was closed without implementation.
78%
#472 style: enable ty by default starbase merged Merged to enable the ty type checker by default. Approved by two reviewers with all CI checks passing. The minimal configuration change lays groundwork for eventually replacing mypy and pyright once ty reaches stable release.
74%
#1007 style: drop mypy, pyright craft-providers merged Removes mypy and pyright type checkers in favor of ty, updating Makefile, common.mk, pyproject.toml, and uv.lock across 16 files (+24/-241). Fresh maintainer PR, CI green, pending review; directly implements issue #901.
71%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged after approval by two reviewers and passing CI checks. Replaces mypy and pyright with the ty type checker across three files, reducing 266 lines.
71%
#215 style: drop mypy, pyright craft-grammar merged Merged a pull request replacing mypy and pyright with the ty type checker. After passing all CI checks and receiving two approvals, the change was successfully integrated, removing 481 lines of configuration across six files.
70%