← Back to issue list

style: drop mypy, pyright

View original Github issue

Metadata

Project
craft-providers
Number
#1007
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Squash
Created
Updated
Closed

Current evaluation

⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.

Removes mypy and pyright type checkers in favor of ty, updating Makefile, common.mk, pyproject.toml, and uv.lock across 16 files (+24/-241). Fresh maintainer PR, CI green, pending review; directly implements issue #901.

Suggested action: needs review

Reason: The PR is 0 days old, authored by maintainer mr-cal, and all CI checks pass with no failing jobs, so it is ready for a maintainer review to land. It directly implements open issue #901 ('Remove mypy and pyright'), and pyproject.toml's [tool.ty.rules] comment explicitly references that issue, confirming the change is intentional and tracked.

Impact: 25 Quick Win: 15.0 Staleness: 5 Complexity: 40 Confidence: 85

Issue body

Drops mypy and pyright in favor of ty. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 25
Quick Win: 15.0
Staleness: 5
Complexity: 40
Confidence: 85
needs review Removes mypy and pyright type checkers in favor of ty, updating Makefile, common.mk, pyproject.toml, and uv.lock across 16 files (+24/-241). Fresh maintainer PR, CI green, pending review; directly implements issue #901.
qwen/qwen3.8-27b
Impact: 15
Quick Win: 12.0
Staleness: 0
Complexity: 20
Confidence: 85
needs review Removes mypy and pyright type checkers in favor of ty across 16 files (+24/-241), including Makefile, pyproject.toml and CI config. Fresh PR by a maintainer, 0 reviewers, fast CI passing with slow tests still pending.
qwen/qwen3.8-27b
Impact: 25
Quick Win: 16.25
Staleness: 5
Complexity: 35
Confidence: 85
needs review Drops mypy and pyright type checkers in favor of ty, updating Makefile, common.mk, pyproject.toml, and uv.lock (+24/-241 across 16 files). Fresh maintainer PR; CI mostly passing with slow tests pending, no review yet.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
created

Related work

  • Caused By: craft-providers#901 (confidence 90%)

    Issue #901 'Remove mypy and pyright' is the tracked enhancement to migrate to ty; pyproject.toml's [tool.ty.rules] comment cites it as the reason the unused-type-ignore-comment rule was temporarily disabled.

Related issues

Issue Project State Summary Similarity
#479 style: drop mypy, pyright craft-cli merged Merged after approval from two reviewers; replaces mypy and pyright with ty, passing all CI checks. The change removed 341 lines and added 17 across 8 files.
82%
#152 style: remove mypy and pyright to go all-in on ty debcraft merged Merged changes removing mypy and pyright type checkers to exclusively use the ty tool. Approved by two reviewers, passed CI checks, and modified 12 files with a net reduction of 154 lines.
82%
#421 style: drop mypy, pyright craft-store merged Merged after approval from two reviewers; all CI checks passed. Replaces mypy and pyright with ty, removing 413 lines and adding 27 across 13 files.
82%
#253 style: drop mypy, pyright craft-archives merged Merged after approval and passing CI. Removes mypy and pyright, replacing them with ty; 13 files changed (+16/-506).
81%
#215 style: drop mypy, pyright craft-grammar merged Merged a pull request replacing mypy and pyright with the ty type checker. After passing all CI checks and receiving two approvals, the change was successfully integrated, removing 481 lines of configuration across six files.
81%
#1706 style: drop mypy, pyright craft-parts merged Merged after approval and passing CI. Replaced mypy and pyright with ty for type checking across 88 files. Redundant isinstance checks were deferred to a separate issue.
81%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged after approval by two reviewers and passing CI checks. Replaces mypy and pyright with the ty type checker across three files, reducing 266 lines.
80%
#420 Remove mypy and pyright craft-cli closed Replaced mypy and pyright with ty for type checking. The cleanup was completed and merged via pull request #479.
77%
#901 Remove mypy and pyright craft-providers open Enhancement to remove mypy and pyright type checkers in favor of ty, following similar work in snapcraft#6007. Issue created by maintainer but has had no maintainer response or comments in 136 days.
77%
#1084 style: replace mypy and pyright with ty craft-application merged Merged a squashed pull request replacing mypy and pyright with ty for type checking across 70 files. Approved by two reviewers with all CI checks passing, the change streamlines the linting configuration for craft-app 7.
76%