← Back to issue list

style: drop mypy, pyright

View original Github issue

Metadata

Project
craft-providers
Number
#1007
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Squash
Created
Updated
Closed

Current evaluation

Merged into main as commit 232143d, replacing mypy and pyright with ty and removing obsolete type-checker tooling.

Resolution: closed resolved

Reason: PR #1007 was approved and merged, with commit 232143d changing the lint setup to use ty and remove mypy/pyright-related tooling and suppressions.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Drops mypy and pyright in favor of ty. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into main as commit 232143d, replacing mypy and pyright with ty and removing obsolete type-checker tooling.
stealth/space-bunny-alpha — closed resolved Merged PR #123 replaced mypy and pyright with ty, removing 241 lines of tooling and obsolete suppressions.
qwen/qwen3.6-35b-a3b — — Merged changes dropping mypy and pyright in favor of ty. Approved by two reviewers with all CI checks passing. The update modifies 16 files, removing 241 lines and adding 24.
qwen/qwen3.8-27b
Impact: 25
Quick Win: 15
Staleness: 5
Complexity: 40
Confidence: 85
needs review Removes mypy and pyright type checkers in favor of ty, updating Makefile, common.mk, pyproject.toml, and uv.lock across 16 files (+24/-241). Fresh maintainer PR, CI green, pending review; directly implements issue #901.
qwen/qwen3.8-27b
Impact: 15
Quick Win: 12
Staleness: 0
Complexity: 20
Confidence: 85
needs review Removes mypy and pyright type checkers in favor of ty across 16 files (+24/-241), including Makefile, pyproject.toml and CI config. Fresh PR by a maintainer, 0 reviewers, fast CI passing with slow tests still pending.
qwen/qwen3.8-27b
Impact: 25
Quick Win: 16
Staleness: 5
Complexity: 35
Confidence: 85
needs review Drops mypy and pyright type checkers in favor of ty, updating Makefile, common.mk, pyproject.toml, and uv.lock (+24/-241 across 16 files). Fresh maintainer PR; CI mostly passing with slow tests pending, no review yet.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#1706 style: drop mypy, pyright craft-parts merged Merged PR #1706 in commit 770e2130, replacing mypy and pyright with ty; redundant runtime type-check cleanup was deferred to #1707.
88%
#253 style: drop mypy, pyright craft-archives merged Merged PR #253 (commit 1949f53) drops mypy and pyright in favor of ty; lint and test CI checks passed.
88%
#479 style: drop mypy, pyright craft-cli merged Merged PR #479 (commit 0e49c01) dropped the mypy and pyright type checkers in favour of ty, removing ~340 lines of type-checker config and ignore directives across 8 files; all CI checks passed.
87%
#215 style: drop mypy, pyright craft-grammar merged Merged #215 in commit 19a38b7, dropping mypy and pyright in favor of ty across six files (+4/-481).
86%
#420 Remove mypy and pyright craft-cli closed Removed mypy and pyright in favor of ty through merged PR #479 (commit 0e49c01).
81%
#6247 style: go all-in on ty snapcraft merged Merged PR #6247 (commit 534d7dce7) replaced mypy and pyright with ty, removed obsolete suppressions, and resolved #6007.
79%
#6007 Remove mypy and pyright snapcraft closed Request to drop mypy and pyright for ty was resolved by merged PR #6247 ("style: go all-in on ty", commit 534d7dce7), which replaced both checkers with ty and removed the unused-ignore-comment suppression.
79%
#421 style: drop mypy, pyright craft-store merged Merged #421 to replace mypy and pyright with Astral ty; the lint pipeline now runs lint-ty.
79%
#1207 style: replace mypy and pyright with ty rockcraft merged Merged PR #1207 (commit 5d9356c1), replacing mypy and pyright type checking with Astral ty and updating lint configuration across 43 files.
78%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged PR #223 by lengau replaced mypy and pyright with the ty type checker in craft-platforms, dropping ~274 lines across 3 files; approved by 2 reviewers with all lint/test CI green.
78%