← Back to issue list

style: enable ty by default

View original Github issue

Metadata

Project
starbase
Number
#472
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #472 as commit 7982765, making Astral ty a default type-checking option while retaining existing checkers.

Resolution: closed resolved

Reason: PR #472 was approved and merged with all CI checks passing, landing as commit 7982765. It enabled ty by default in the lint workflow.

Evaluated by: mr-cal-bot

No scores available.

Issue body

<!-- Describe your changes --> --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #472 as commit 7982765, making Astral ty a default type-checking option while retaining existing checkers.
stealth/space-bunny-alpha — closed resolved Merged #472 (commit 7982765), enabling ty by default in the lint configuration.
qwen/qwen3.6-35b-a3b — — Merged to enable the ty type checker by default. Approved by two reviewers with all CI checks passing. The minimal configuration change lays groundwork for eventually replacing mypy and pyright once ty reaches stable release.
qwen3.6-35b-a3b-mtp-q6 — — Merged to enable the ty type checker by default in the linting configuration. The maintainer plans to replace mypy and pyright with ty once it reaches version 0.1.0, as it aims to cover issues from both tools. Linting and tests passed.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/starbase#429 (confidence 98%)

    Earlier merged PR introduced ty as an optional linter.

  • Related To: canonical/starbase#534 (confidence 95%)

    Follow-up PR corrected ty to target the project virtual environment.

Related issues

Issue Project State Summary Similarity
#407 style(types): enable type checking with ty craft-cli merged Merged as d38e0f4: enabled Astral ty type checking, added it to the lint workflow, and included it in lint build dependencies.
81%
#139 style(type): fix typing issues found by ty craft-platforms merged Merged as commit 1a30eec, fixing type-checking edge cases found by ty; the remaining diagnostic was an upstream false positive tracked in astral-sh/ty#553.
79%
#2726 style: switch type checking to ty charmcraft merged PR #2726 merged as commit f2e05e81, switching Charmcraft type checking to Astral ty and fixing existing ty errors.
78%
#201 style: enable ty as stable type checker craft-platforms merged Merged in craft-platforms#201 (commit 5407de0), enabling ty as the stable type checker in regular checks while retaining pyright and mypy for now.
75%
#885 style: enable type checking with ty craft-providers merged Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed.
75%
#200 style: enable ty as stable type checker craft-platforms closed Superseded by canonical/craft-platforms#201, which merged commit 5407de0 to add ty as the stable type checker while retaining mypy and pyright.
73%
#207 style: disable pyright in favour of ty craft-platforms merged Merged as f287a56, replacing the active Pyright configuration with Astral’s ty type checker.
72%
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
72%
#1207 style: replace mypy and pyright with ty rockcraft merged Merged PR #1207 (commit 5d9356c1), replacing mypy and pyright type checking with Astral ty and updating lint configuration across 43 files.
71%