fix(test): better matching for strict dependencies spread test
Metadata
Current evaluation
Merged PR #1322 in commit 7c3170d3, improving the expected-output matching in the strict-dependencies spread test.
Resolution: closed resolved
Reason: PR #1322 was merged after approval by two reviewers. Commit 7c3170d3 contains the one-line test fix.
Evaluated by: mr-cal-bot
No scores available.
Issue body
No description provided.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1322 in commit 7c3170d3, improving the expected-output matching in the strict-dependencies spread test. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged maintainer test fix to improve matching for the strict-dependencies spread test; one-line change, approved by two reviewers. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a single-line test fix improving matching logic for the strict dependencies spread test. Approved by two reviewers with zero unresolved comments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a test fix improving matching logic for the strict dependencies spread test. The change was integrated into the codebase by maintainer lengau without further discussion. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1266 tests(spread): requirements dependencies | charmcraft | merged | Merged PR #1266 at 97d95b39, adding spread tests for requirements-file and charm-dependency combinations; the PR explicitly fixes #1179. | |
| #723 fix(testing): more intelligent test handling | craft-application | merged | Merged PR #723 via commit 6b319b77, running Spread tests as root and strictly validating only top-level spread.yaml keys. | |
| #1382 test: use MATCH in spread tests | charmcraft | merged | Merged in charmcraft#1382 (commit 90f23622), replacing grep assertions with MATCH in four spread-test files so missing expected output correctly fails tests. | |
| #1366 tests(spread): make release test less flaky | charmcraft | merged | Merged #1366 at commit 05b18a03, reducing flakiness in the Spread release test and resolving #1362. | |
| #701 fix(TestingService): error better when we can't find spread | craft-application | merged | Merged PR #701 as bb2bda9c, improving the TestingService error when spread is missing from PATH; fixes #697. | |
| #775 feat: add support to spread test expressions | craft-application | merged | Merged PR #775 as commit 7f70ecb0, adding Spread test-expression matching and CI filtering; fixes issue #748. | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged PR #534 (commit 4f89bb7) worked around #533 by skipping the flaky snap names-query assertion while retaining the other spread-test checks. |