fix(testing): more intelligent test handling
Metadata
Current evaluation
Merged PR #723 via commit 6b319b77, running Spread tests as root and strictly validating only top-level spread.yaml keys.
Resolution: closed resolved
Reason: PR #723 was approved and merged into the main branch as commit 6b319b77, implementing improved Spread test handling and top-level spread.yaml validation.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This runs spread tests as root and strictly parses only the top level of spread.yaml keys.
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #723 via commit 6b319b77, running Spread tests as root and strictly validating only top-level spread.yaml keys. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/craft-application#723 (commit 6b319b77): runs Spread tests as root and strictly validates only top-level spread.yaml keys. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as canonical/craft-application#723 (6b319b77), running Spread tests as root and strictly validating only top-level spread.yaml keys. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #723 in commit 6b319b77 to run Spread tests as root and strictly validate only top-level spread.yaml keys. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval. Updates test handling to run spread tests as root and strictly parse top-level spread.yaml keys. Approved by two reviewers and passed CI checks before integration. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #717 fix(test): minor test fixes | craft-application | merged | Merged PR #717 (commit 9f02b30f) switched spread tests to streaming output and adopted Spread's new reroot key, fixing #704 and #715. | |
| #1029 fix(testing): error early if spread.yaml is invalid. | craft-application | merged | PR #1029 merged (commit 93c27ec5): TestingService now reads and validates spread.yaml before starting the lifecycle, erroring early on invalid files. Changelog entry added under 6.3.0. | |
| #592 feat(testing): execute spread on generated file | craft-application | merged | Merged #592: the test command now resolves the backend, writes a temporary spread.yaml, and executes Spread against the generated file. | |
| #291 Refactor spread testing to use spread extensions | fetch-service | closed | Fixed by merged PR #299 (commit 44d9906), which refactored spread tests to generate spread.yaml and use the new spread extension framework. | |
| #1366 tests(spread): make release test less flaky | charmcraft | merged | Merged #1366 at commit 05b18a03, reducing flakiness in the Spread release test and resolving #1362. | |
| #565 feat(testing): process simplified spread.yaml | craft-application | merged | Merged PR #565 added simplified spread.yaml expansion into a complete project file, resolving #560 after approval by two reviewers. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%. | |
| #5389 test(spread): trace logs in spread tests | snapcraft | merged | Merged PR #5389 as ff6f5950e, adding trace logging to spread tests for better failure diagnostics. | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged PR #534 (commit 4f89bb7) worked around #533 by skipping the flaky snap names-query assertion while retaining the other spread-test checks. | |
| #3662 tests: update spread url | snapcraft | merged | Merged PR #3662 updated Spread tarball URLs in two test files via commit 507959d70. |