← Back to issue list

fix(testing): more intelligent test handling

View original Github issue

Metadata

Project
craft-application
Number
#723
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after approval. Updates test handling to run spread tests as root and strictly parse top-level spread.yaml keys. Approved by two reviewers and passed CI checks before integration.

Suggested action:

No scores available.

Issue body

This runs spread tests as root and strictly parses only the top level of spread.yaml keys. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval. Updates test handling to run spread tests as root and strictly parse top-level spread.yaml keys. Approved by two reviewers and passed CI checks before integration.
qwen3.6-35b-a3b-mtp-q6 Merged updates to test handling that run spread tests as root and strictly parse only top-level spread.yaml keys.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1029 fix(testing): error early if spread.yaml is invalid. craft-application merged Merged after two approvals. Adds early validation to fail tests immediately if spread.yaml is invalid. CI passed except for an unrelated snap-test failure, which was overridden.
78%
#3662 tests: update spread url snapcraft merged Merged update to spread tarball URLs in test files. Approved by a reviewer, passed CI checks, modified two files with minimal changes, and maintained existing code coverage.
76%
#127 Fix spread tests imagecraft merged Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines).
76%
#62 spread: add a "big" spread test rockcraft merged Merged a reusable spread test framework to house multiple checks without repeated setup. The initial test validates bug #44 regarding directory permissions. Approved by one reviewer and passed CI checks.
76%
#534 test(spread): workaround for flaky test fetch-service merged Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks.
76%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration.
76%
#13 test(spread): add more spread tests snapcraft-rocks merged Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines).
76%
#1705 test: extend timeout for some spread tests charmcraft merged Merged changes extending timeouts for specific spread tests to prevent failures from lengthy preparation steps. Approved by reviewers, passed CI, and modified two files.
75%
#565 feat(testing): process simplified spread.yaml craft-application merged Merged to resolve issue #560. Processes a user-supplied simplified spread.yaml into a complete project file for the spread testing framework. Approved by two reviewers, passed CI, and modified 11 files.
75%
#3663 tests: update spread url snapcraft merged Merged following reviewer approval and passing CI. Updated spread tarball URLs in test configuration files, modifying two files with minimal changes.
75%