test: use MATCH in spread tests
Metadata
Current evaluation
Merged updates replacing direct grep calls in spread tests with MATCH to ensure reliable test failure detection. Approved by three reviewers and modified four files.
Suggested action: —
No scores available.
Issue body
We've got a few places where we use grep directly in a way that doesn't guarantee test failure when it should.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged updates replacing direct grep calls in spread tests with MATCH to ensure reliable test failure detection. Approved by three reviewers and modified four files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to spread tests that replace direct grep calls with MATCH, ensuring reliable test failure detection when assertions should trigger. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to replace direct grep usage in spread tests with MATCH, ensuring reliable test failure detection when expected patterns are missing. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1322 fix(test): better matching for strict dependencies spread test | charmcraft | merged | Merged a single-line test fix improving matching logic for the strict dependencies spread test. Approved by two reviewers with zero unresolved comments. | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks. | |
| #926 test: address a couple of non-flaky spread failures | rockcraft | merged | Merged after two approvals and passing all CI checks. Resolves non-flaky spread test failures by updating test configurations across three files, eliminating consistent failures. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration. | |
| #2379 test(spread): per-base destructive mode tests | charmcraft | merged | Merged following approval by two reviewers. Added per-base destructive mode tests for spread and removed a redundant uv test. Changes were integrated despite mixed CI results. | |
| #3662 tests: update spread url | snapcraft | merged | Merged update to spread tarball URLs in test files. Approved by a reviewer, passed CI checks, modified two files with minimal changes, and maintained existing code coverage. | |
| #723 fix(testing): more intelligent test handling | craft-application | merged | Merged after approval. Updates test handling to run spread tests as root and strictly parse top-level spread.yaml keys. Approved by two reviewers and passed CI checks before integration. | |
| #62 spread: add a "big" spread test | rockcraft | merged | Merged a reusable spread test framework to house multiple checks without repeated setup. The initial test validates bug #44 regarding directory permissions. Approved by one reviewer and passed CI checks. | |
| #127 Fix spread tests | imagecraft | merged | Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines). | |
| #1290 test(spread): clean up store tests | charmcraft | merged | Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers. |