← Back to issue list

fix(templates): replace flake8 and pydocstyle with ruff

View original Github issue

Metadata

Project
charmcraft
Number
#1941
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1941 (commit 9aba24c4) replaced flake8 and pydocstyle with Ruff in Charmcraft templates, resolving #1461.

Resolution: closed resolved

Reason: PR #1941 is merged and explicitly states “Fixes #1461.” Commit 9aba24c4 records the template migration from flake8 and pydocstyle to Ruff.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #1461

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1941 (commit 9aba24c4) replaced flake8 and pydocstyle with Ruff in Charmcraft templates, resolving #1461.
stealth/space-bunny-alpha — closed resolved Merged PR #1941 in commit 9aba24c4, replacing flake8 and pydocstyle in Charmcraft templates with ruff and resolving #1461.
qwen/qwen3.6-35b-a3b — — Merged changes replacing flake8 and pydocstyle with ruff in the templates directory. Approved by three reviewers, the update modifies 14 files and resolves issue #1461.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes replacing flake8 and pydocstyle with ruff for template linting, resolving issue #1461. The update consolidates code quality checks into a single, faster tool.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: charmcraft#1461 (confidence 100%)

    PR #1941 explicitly links to and fixes issue #1461.

Related issues

Issue Project State Summary Similarity
#1461 Replace flake8 and pydocstyle template tests with ruff charmcraft closed Ruff replaced flake8 and pydocstyle in Charmcraft template validation via merged PR #1941 (commit 9aba24c4).
92%
#932 feat: replace flake8 + plugins and isort with ruff charmcraft merged Merged PR #932 (commit ac847a31, branch ruff-in-template) replaced flake8 + plugins and isort with Ruff in charmcraft, cutting the lint dependency tree and CI instability from flake8 plugin breakage.
85%
#2383 style: update to ruff 0.12 charmcraft merged Merged PR #2383 updated Charmcraft to Ruff 0.12 and applied the associated lint and formatting changes across nine files.
79%
#739 chore: remove flake8 and pydocstyle rockcraft merged Merged #739, removing flake8 and pydocstyle after replacing them with Ruff; commit 6939aba5.
77%
#288 lint: add ruff, remove autoflake, flake8, isort, pydocstyle, pylint craft-providers merged Merged PR #288 in commit 42a7920, replacing autoflake, flake8, isort, pydocstyle, and pylint with Ruff; deferred Ruff rule cleanup was tracked in #287.
76%
#2229 style: fix linting errors charmcraft merged Merged charmcraft#2229 as commit 134e1cb6, fixing lint failures from the latest Ruff and Pyright across eight files.
76%
#1378 build: replace `black` with `ruff format` in charmcraft templates charmcraft merged PR #1378 merged as commit 485a756c, swapping black for ruff format/check in the scaffolded charm templates (tox.ini/pyproject) and bumping the default ops version to 2.8.
76%
#1517 build: update ruff settings charmcraft merged Merged into charmcraft as commit 33854f04, updating the project's Ruff lint configuration (+6/-6).
75%
#1329 test(style): remove pydocstyle tests on charmcraft code charmcraft merged Merged in commit e7c55c88: removed redundant pydocstyle tests covered by Ruff and relocated init-command test helpers.
75%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged PR canonical/craft-application#580 (commit 97347705) by lengau applied style-only fixes (+7/-7, 3 files) for new lint failures caused by a Ruff update; approved by 3 reviewers.
71%