← Back to issue list

fix(templates): replace flake8 and pydocstyle with ruff

View original Github issue

Metadata

Project
charmcraft
Number
#1941
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged changes replacing flake8 and pydocstyle with ruff in the templates directory. Approved by three reviewers, the update modifies 14 files and resolves issue #1461.

Suggested action:

No scores available.

Issue body

Fixes #1461

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes replacing flake8 and pydocstyle with ruff in the templates directory. Approved by three reviewers, the update modifies 14 files and resolves issue #1461.
qwen3.6-35b-a3b-mtp-q6 Merged changes replacing flake8 and pydocstyle with ruff for template linting, resolving issue #1461. The update consolidates code quality checks into a single, faster tool.
qwen3.6-35b-a3b-mtp-q6 Merged a pull request replacing flake8 and pydocstyle with ruff in the templates directory, resolving issue #1461.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#739 chore: remove flake8 and pydocstyle rockcraft merged Merged removal of flake8 and pydocstyle in favor of ruff. Approved by two reviewers, passed CI, and updated four files with a net reduction of 53 lines.
82%
#932 feat: replace flake8 + plugins and isort with ruff charmcraft merged Merged after approval and passing CI checks, replacing flake8, plugins, and isort with ruff to resolve CI instability from dependency conflicts. Updated six files to streamline Python linting.
80%
#2229 style: fix linting errors charmcraft merged Merged changes resolving linting errors from the latest ruff and pyright. Approved by two reviewers with zero unresolved comments. Updated 8 files, removing 22 lines overall.
79%
#1461 Replace flake8 and pydocstyle template tests with ruff charmcraft closed Closed without a linked pull request or comments, indicating the task was abandoned or resolved separately.
78%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged after approval by three reviewers. Resolves linting errors from a ruff update, modifying three files with a +7/-7 line change. Successfully integrated into the codebase.
76%
#1288 style: fix ruff PTH211 errors craft-parts merged Merged to resolve Ruff 0.13 PTH211 lint violations. Approved by two reviewers with all CI checks passing. Updated eight files to correct style errors.
75%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged after two approvals and passing all CI checks. Resolves linting compatibility issues with newer ruff versions, updating five files.
75%
#337 Linters: migrate from flake8 to ruff craft-parts merged Merged after approval, migrating linters from flake8 to ruff. Ruff is now the default, with flake8 retained as an optional make target. 4 files changed.
74%
#969 style: fix linting issues for ruff 0.9 craft-parts merged Merged a minor style fix addressing linting issues for ruff 0.9. Approved by two reviewers, passed CI checks, and updated two files with a net change of one line.
74%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged after approval by two reviewers. Resolves linting failures introduced by ruff 0.12 across 14 files. CI passed for fast tests, linting, and security scans, while slow test failures were tracked separately in #804.
74%