← Back to issue list

style: fix linting errors

View original Github issue

Metadata

Project
charmcraft
Number
#2229
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged charmcraft#2229 as commit 134e1cb6, fixing lint failures from the latest Ruff and Pyright across eight files.

Resolution: closed resolved

Reason: PR #2229 was approved by two reviewers and merged into the main branch as commit 134e1cb6, applying the requested Ruff and Pyright lint fixes.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fix linting errors from both the latest ruff and the latest pyright.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged charmcraft#2229 as commit 134e1cb6, fixing lint failures from the latest Ruff and Pyright across eight files.
stealth/space-bunny-alpha — closed resolved Merged charmcraft#2229, fixing lint errors from the latest Ruff and Pyright across 8 files (+26/-22); approved by two reviewers.
qwen/qwen3.6-35b-a3b — — Merged changes resolving linting errors from the latest ruff and pyright. Approved by two reviewers with zero unresolved comments. Updated 8 files, removing 22 lines overall.
qwen3.6-35b-a3b-mtp-q6 — — Merged a style update resolving linting errors from the latest ruff and pyright versions. The maintainer applied formatting and type-checking fixes to align with updated tooling standards.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2383 style: update to ruff 0.12 charmcraft merged Merged PR #2383 updated Charmcraft to Ruff 0.12 and applied the associated lint and formatting changes across nine files.
80%
#2819 fix(tests): resolve ruff lint failures in test suite charmcraft merged Merged charmcraft#2819, fixing four Ruff CI failures by making excess pytest arguments keyword-only and parenthesizing implicit string concatenations in tests.
78%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
77%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged #1465 as a58695ef, fixing five files (+13/-6) for compatibility with newer Ruff; all CI checks passed.
77%
#1517 build: update ruff settings charmcraft merged Merged into charmcraft as commit 33854f04, updating the project's Ruff lint configuration (+6/-6).
76%
#1941 fix(templates): replace flake8 and pydocstyle with ruff charmcraft merged Merged PR #1941 (commit 9aba24c4) replaced flake8 and pydocstyle with Ruff in Charmcraft templates, resolving #1461.
76%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804.
75%
#969 style: fix linting issues for ruff 0.9 craft-parts merged Merged as commit f1427855: small Ruff 0.9 lint fixes (+2/-1) across 2 files, following the ruff-pre-commit hook bump to the 0.9.x series.
75%
#580 style(ruff): fix linting issues from ruff update craft-application merged Merged PR canonical/craft-application#580 (commit 97347705) by lengau applied style-only fixes (+7/-7, 3 files) for new lint failures caused by a Ruff update; approved by 3 reviewers.
75%
#901 style: fix ruff 0.13 linting issues craft-application merged Merged in canonical/craft-application#901 via commit 0a659742, fixing Ruff 0.13 linting with a one-line change; review was approved and all CI checks passed.
75%