← Back to issue list

feat(craft-app): move init command

View original Github issue

Metadata

Project
charmcraft
Number
#1340
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #1340 by lengau merged, relocating charmcraft's init command into craft-application (with the init service/command/tests) plus lint fixes (+500/-343, 18 files). Later cleanup commit 97fa9229 (#1520) removed the old implementation.

Resolution: closed resolved

Reason: The pull request was merged after approval by 3 reviewers, landing the init command and its supporting service in craft-application. The follow-up refactor commit 97fa9229 ("refactor: remove old 'init' command implementation", PR #1520) confirms the migration completed, and tracking issue #1153 was closed as a result.

Evaluated by: mr-cal-bot

No scores available.

Issue body

includes lint fixes needed for this update

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #1340 by lengau merged, relocating charmcraft's init command into craft-application (with the init service/command/tests) plus lint fixes (+500/-343, 18 files). Later cleanup commit 97fa9229 (#1520) removed the old implementation.
stealth/space-bunny-alpha — closed resolved Merged PR #1340 moved the craft-app init command and included required lint fixes.
qwen/qwen3.6-35b-a3b — — Merged maintainer PR moving the craft-app init command. Includes required lint fixes, approved by three reviewers, and modifies 18 files (+500/-343 lines).
qwen3.6-35b-a3b-mtp-q6 — — Merged the feat(craft-app): move init command pull request, relocating the init command and applying required lint fixes.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1153 (confidence 90%)

    Tracking issue "Move the init command to craft-application" was closed by this PR.

  • Likely Fixed By: canonical/charmcraft#1520 (confidence 80%)

    Later refactor removing the old in-tree init implementation, confirming the migration to craft-application.

  • Related To: canonical/craft-application#522 (confidence 55%)

    Companion upstream PR adding the init service, command and tests on the craft-application side.

Related issues

Issue Project State Summary Similarity
#1153 Move the init command to craft-application charmcraft closed Init moved to craft-application and was adopted by Charmcraft in merged PR canonical/charmcraft#1340; upstream PR canonical/craft-application#522 landed it in commit f2a4becf.
85%
#1364 feat(craft-application): miscellaneous commands charmcraft merged Merged #1364 into main, adding craft-application analyse and extension-related commands. A charmcraft init failure reported on the PR was addressed by follow-up PR #1367.
79%
#1520 refactor: remove old "init" command implementation charmcraft merged Merged PR #1520 in commit 97fa9229, removing 248 lines of obsolete init command code after the craft-application transition.
79%
#1330 feat(craft-app): Add craft-application services charmcraft merged Merged PR #1330 added craft-application services. The author corrected init-related changes so charm builds worked; a provider-test hang was attributed to the local environment.
78%
#1399 feat: craft-application rebase charmcraft merged Merged PR #1399 (commit 3ba803d1) rebased Charmcraft onto craft-application for CRAFT-2239, a 109-file rewrite of the CLI foundation; cmatsuoka approved merging with remaining issues deferred to follow-up PRs.
75%
#1571 refactor: remove unused clean command implementation charmcraft merged Merged PR #1571 as commit 053d5a2d, removing the obsolete Charmcraft clean command and regression tests after craft-application took over clean handling.
74%
#1544 feat: update charmcraft to use craft-application from main charmcraft merged Merged #1544 to track craft-application main for CRAFT-2543; follow-up #1596 later pinned the released 2.0.0 dependency.
74%
#360 Migrate non-lifecycle commands to craft-application rockcraft closed Resolved by merged PR #761 (commit 484099f5), which adopted craft-application’s upstream Init command/service and added --project-dir support.
73%
#5129 refactor: use init command from craft-application snapcraft merged Merged PR #5129 (de05a733d) replaced Snapcraft’s init command with craft-application’s, fixed #5098, and added name, profile, and project-dir options.
73%
#1358 feat(craft-application): migrate store commands charmcraft merged Merged PR #1358 migrated Charmcraft store commands to craft-application, completing #1284; 5cb01186 contains the mechanical migration, and 9da46c37 later removed legacy implementations.
73%