← Back to issue list

feat: basic store service

View original Github issue

Metadata

Project
charmcraft
Number
#1459
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/charmcraft#1459 (5dcad2af), adding a craft-application-style StoreService for store commands with Charmcraft-specific defaults.

Resolution: closed resolved

Reason: PR #1459 was approved and merged into Charmcraft as commit 5dcad2af. It introduced an application-agnostic store service for running store commands.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This creates a craft-application style `StoreService` for running store commands. The service is mostly written to be application agnostic so we could later upstream it if we want, but the default values are the ones that are convenient for Charmcraft.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#1459 (5dcad2af), adding a craft-application-style StoreService for store commands with Charmcraft-specific defaults.
stealth/space-bunny-alpha — closed resolved Merged #1459 in commit 5dcad2af, adding a craft-application-style StoreService for store commands with Charmcraft-specific defaults.
stealth/space-bunny-alpha — closed resolved Merged in charmcraft/charmcraft#1459 (5dcad2af), adding a craft-application-style StoreService for running store commands with Charmcraft-specific defaults.
qwen/qwen3.6-35b-a3b — — Merged an application-agnostic StoreService for executing store commands, configured with Charmcraft defaults. Approved by two reviewers, the update adds 392 lines across eight files.
qwen3.6-35b-a3b-mtp-q6 — — Merged an application-agnostic StoreService for executing store commands, configured with Charmcraft defaults. The maintainer implemented it to enable future upstreaming while providing immediate functionality.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1358 feat(craft-application): migrate store commands charmcraft merged Merged PR #1358 migrated Charmcraft store commands to craft-application, completing #1284; 5cb01186 contains the mechanical migration, and 9da46c37 later removed legacy implementations.
74%
#1154 Use craft-application's store service charmcraft open Store interactions now use a craft-application AppService, and all store commands inherit AppCommand; completed by commit 5dcad2af and related craft-application migration work.
73%
#682 Upstream Charmcraft's store service craft-application open Move Charmcraft's store service into craft-application to remove duplicated code; it remains open, unlabeled, and unresolved pending triage.
72%
#565 store: replace implementation with craft-store (CRAFT-491) charmcraft merged Merged #565 into main, replacing Charmcraft's store implementation with craft-store for CRAFT-491 (merge commit 70ba8e28).
70%