fix: final spread test fixes for craft-application
Metadata
Current evaluation
Merged after approval by two reviewers. Resolves final spread test issues for craft-application across seven files, removing 127 lines and adding 104. Changes integrated into the main branch.
Suggested action: —
No scores available.
Issue body
No description provided.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval by two reviewers. Resolves final spread test issues for craft-application across seven files, removing 127 lines and adding 104. Changes integrated into the main branch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged maintainer lengau's changes to fix final spread tests in craft-application. The pull request resolved test failures associated with spread functionality, ensuring correct behavior within the craft-application module. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged maintainer pull request applying final spread test fixes to craft-application. The changes were integrated directly without additional discussion. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1381 fix: fix most spread tests on craft-application | charmcraft | merged | Merged updates fixing most spread tests for craft-application. Two smoketests remain broken. Approved despite minor linting and unit test failures. Resolves CRAFT-2239. | |
| #1563 fix: breaking changes from craft-application main | charmcraft | merged | Merged to resolve breaking changes from craft-application main. Approved by two reviewers, the update modified five files (+46/-26 lines) and was successfully integrated into the codebase. | |
| #726 fix(spread): include project in craft-spread model | craft-application | merged | Merged a fix to include the project field in the craft-spread model. Approved by two reviewers, passed most CI checks despite one failing test, and merged by maintainer lengau. Modified two files. | |
| #1454 build: update craft-application | charmcraft | merged | Merged after updating the craft-application dependency and adjusting test constants. Approved by two reviewers with no unresolved comments. Changes affect three files with minor line adjustments. | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests. | |
| #2118 fix: remove experimental spread init templates | charmcraft | merged | Merged removal of experimental spread init templates from the init command. Replaced by proper testing support in craft-application. Existing files remain unaffected. Approved by three reviewers and passed CI. | |
| #1325 test(spread): consolidate basic init/build tests | charmcraft | merged | Merged after approval by two reviewers. Consolidates basic init and build spread tests across four files, reducing 80 lines and adding 28. Resolves CRAFT-2127. | |
| #4659 fix: update to craft-application latest | snapcraft | merged | Merged. Consolidates fixes from PRs #4616, #4643, and #4651 to update craft-application to the latest version and accommodate its main branch breaking changes. Approved by two reviewers, passed CI, and successfully merged. | |
| #1330 feat(craft-app): Add craft-application services | charmcraft | merged | Merged feat(craft-app): Add craft-application services. Approved by two reviewers, the change modified 56 files with 2143 additions and 230 deletions. The author fixed changelist misalignments causing spread test failures before merge. | |
| #386 tests: update testing to use craft-test | fetch-service | merged | Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines). |