fix: fix most spread tests on craft-application
Metadata
Current evaluation
Merged updates fixing most spread tests for craft-application. Two smoketests remain broken. Approved despite minor linting and unit test failures. Resolves CRAFT-2239.
Suggested action: —
No scores available.
Issue body
Still broken after this:
- tests/spread/smoketests/different-dir
- tests/spread/smoketests/full-lifecycle
---
CRAFT-2239
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged updates fixing most spread tests for craft-application. Two smoketests remain broken. Approved despite minor linting and unit test failures. Resolves CRAFT-2239. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for most craft-application spread tests. Approved despite minor linting and unit test failures. Two smoketests remain broken post-merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after reviewer approval despite minor linting and unit test failures. The change resolved most spread tests in craft-application, though smoketests for different-dir and full-lifecycle remain broken. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1386 fix: final spread test fixes for craft-application | charmcraft | merged | Merged after approval by two reviewers. Resolves final spread test issues for craft-application across seven files, removing 127 lines and adding 104. Changes integrated into the main branch. | |
| #717 fix(test): minor test fixes | craft-application | merged | Merged minor test fixes replacing spread test pausing with a stream approach and adopting the new reroot key. Resolves issues #704 and #715, plus CRAFT-4399 and CRAFT-4411. Approved by two reviewers with all CI checks passing. | |
| #102 test: update craftctl test | snapcraft-rocks | merged | Merged after two approvals and passing CI checks. Updates the spread test to validate the fix for snapcraft-rocks#33, modifying one file with seven added lines. | |
| #386 tests: update testing to use craft-test | fetch-service | merged | Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines). | |
| #5529 fix: remove test artifact workaround | snapcraft | merged | Merged a fix that removes the snapcraft test artifact location workaround, as craft-application 3.5 now handles this natively. Approved by two reviewers, passed all CI checks, and modified five files. | |
| #1325 test(spread): consolidate basic init/build tests | charmcraft | merged | Merged after approval by two reviewers. Consolidates basic init and build spread tests across four files, reducing 80 lines and adding 28. Resolves CRAFT-2127. | |
| #1454 build: update craft-application | charmcraft | merged | Merged after updating the craft-application dependency and adjusting test constants. Approved by two reviewers with no unresolved comments. Changes affect three files with minor line adjustments. | |
| #16 tests: add spread support | rockcraft | merged | Merged after approval and passing CI, adding spread support to tests per CRAFT-865. | |
| #1287 fix(tests): fixes bundle spread test | charmcraft | merged | Merged. Resolves issue #1262 and CRAFT-2052 by fixing the bundle spread test. Replaced a failing charm path check with Python-based YAML validation. Approved by two reviewers, passed CI, and successfully executed the large spread test. | |
| #6018 fix(craft-test): enable spread tests with 26.04 backends | snapcraft | merged | Merged a fix enabling spread tests for Ubuntu 26.04 backends by routing to the ubuntu-daily remote. This temporary workaround resolves CRAFT-4996, with a permanent fix tracked in CRAFT-5002. Approved and passed CI. |