← Back to issue list

Always log the charmcraft version when indicated.

View original Github issue

Metadata

Project
charmcraft
Number
#140
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #140 as commit 65044e39, moving version logging to MessageHandler so it always reaches the log file and appears in verbose terminal output; partially addressed #48.

Resolution: closed resolved

Reason: PR #140 received maintainer approval and merged as commit 65044e39. It resolved version logging by ensuring MessageHandler records it to the log file and emits it to the terminal in verbose mode.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Moved out the the version logging from Dispatcher's init to the MessageHandler, which will always send it to the file (first thing after configuring that part of the logging) and to the terminal when the mode goes verbose. This is part of #48, but not of all it. It's what was important, though, other two messages remain un-shown because of initialization order, but those two messages will go away (or at least change heavily) when the bootstrap refactor is done (see #139).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #140 as commit 65044e39, moving version logging to MessageHandler so it always reaches the log file and appears in verbose terminal output; partially addressed #48.
stealth/space-bunny-alpha — closed resolved Merged #140, moving charmcraft version logging to MessageHandler so it always reaches the log file and appears in verbose terminal output. Partially addressed #48.
qwen/qwen3.6-35b-a3b — — Merged. Relocated charmcraft version logging from Dispatcher initialization to MessageHandler, guaranteeing consistent file output and terminal display in verbose mode. Approved by two reviewers, passed CI, and addresses part of issue #48.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Moved charmcraft version logging from Dispatcher initialization to MessageHandler, ensuring consistent output to files and verbose terminal logs. Addresses initialization order constraints as part of issue #48.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#48 (confidence 98%)

    PR #140 identifies itself as implementing the important part of the initialization-order logging issue.

  • Related To: canonical/charmcraft#139 (confidence 95%)

    The PR cited the bootstrap refactor as the eventual remedy for two remaining initialization-order messages.

Related issues

Issue Project State Summary Similarity
#49 charmcraft should log where it's logging to, and when the logfile is removed charmcraft closed Implemented via craft-cli#27 (3252b61) and Charmcraft PR #577; verbose runs now report the logfile path. Log retention in #53 removed the need for a deletion notice.
71%