← Back to issue list

Always log the charmcraft version when indicated.

View original Github issue

Metadata

Project
charmcraft
Number
#140
Type
pull request
State
merged
Author
facundobatista
Labels
Created
Updated
Closed

Current evaluation

Merged. Relocated charmcraft version logging from Dispatcher initialization to MessageHandler, guaranteeing consistent file output and terminal display in verbose mode. Approved by two reviewers, passed CI, and addresses part of issue #48.

Suggested action:

No scores available.

Issue body

Moved out the the version logging from Dispatcher's init to the MessageHandler, which will always send it to the file (first thing after configuring that part of the logging) and to the terminal when the mode goes verbose. This is part of #48, but not of all it. It's what was important, though, other two messages remain un-shown because of initialization order, but those two messages will go away (or at least change heavily) when the bootstrap refactor is done (see #139).

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Relocated charmcraft version logging from Dispatcher initialization to MessageHandler, guaranteeing consistent file output and terminal display in verbose mode. Approved by two reviewers, passed CI, and addresses part of issue #48.
qwen3.6-35b-a3b-mtp-q6 Merged. Moved charmcraft version logging from Dispatcher initialization to MessageHandler, ensuring consistent output to files and verbose terminal logs. Addresses initialization order constraints as part of issue #48.
qwen3.6-35b-a3b-mtp-q6 Merged. Relocated version logging from Dispatcher initialization to MessageHandler, guaranteeing file output and terminal display in verbose mode. Resolves initialization order constraints for issue #48.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#46 New functionality from charmcraft (CRAFT-706). craft-cli merged Merged new charmcraft functionality (CRAFT-706) following approval from two reviewers. The update adds approximately 2000 lines across 13 files, successfully integrating the feature set into the codebase.
72%
#701 `charmcraft pack` doesn't include all error output charmcraft closed Fixed in Charmcraft 1.5 via improved instance-internal log retrieval, ensuring full build error output is captured. Closed by maintainer pending user verification on the updated version.
70%
#1619 fix: use charmcraft package version charmcraft merged Merged after approval from two reviewers. Implements a one-line fix to use the charmcraft package version, updating a single file to resolve the versioning configuration.
70%