charmcraft should log where it's logging to, and when the logfile is removed
Metadata
Current evaluation
Implemented via craft-cli#27 (3252b61) and Charmcraft PR #577; verbose runs now report the logfile path. Log retention in #53 removed the need for a deletion notice.
Resolution: closed resolved
Reason: canonical/craft-cli#27 added log-location reporting in commit 3252b61, and Charmcraft integrated it through PR #577. The maintainer confirmed it was integrated on 2021-11-03; #53 established log retention, making the removal notice unnecessary.
Evaluated by: mr-cal-bot
No scores available.
Issue body
When running with `--verbose` it would be useful to see two things:
1. an early log about where things are being logged, e.g.
2020-06-24 10:52:17,239 charmcraft DEBUG Logging to /tmp/charmcraft-log-22sbe9rb
2. a towards-the-end log when and if that logfile is removed, e.g.
2020-06-24 10:56:11,640 charmcraft DEBUG Logfile removed.
(It was in fixing this that I noticed #48).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Implemented via craft-cli#27 (3252b61) and Charmcraft PR #577; verbose runs now report the logfile path. Log retention in #53 removed the need for a deletion notice. | |
| stealth/space-bunny-alpha | — | closed resolved | Added log-location reporting through craft-cli#27 (commit 3252b61) and integrated it in Charmcraft; retaining logfiles made the removal notice from #53 unnecessary. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved by integrating craft-cli. Added startup logging for the log file path. Logfile removal notifications were dropped as files are no longer deleted at the end. Closed. | |
| qwen/qwen3.6-35b-a3b | — | — | Implemented logging location output via the craft-cli library. The logfile removal notification was dropped as craft-cli manages logging differently. The requested path logging is now integrated. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved by integrating the requested log file path and removal notification logging into the craft-cli library. The feature is now implemented and the issue is closed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Fixed via the craft-cli library. The tool now logs the logfile path at startup. The removal notification was dropped since logfiles are no longer deleted at execution end. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-cli#27
(confidence 99%)
Added logfile-location reporting in commit 3252b61.
-
Related To:
canonical/charmcraft#53
(confidence 98%)
Established log retention, so logging that the file was removed was no longer applicable.
-
Likely Fixed By:
canonical/charmcraft#577
(confidence 96%)
Integrated the craft-cli feature for passing and reporting the log filepath.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #53 Keep all latest logs | charmcraft | closed | Log retention moved to craft-cli and was integrated into Charmcraft by merged PR #635 (d36b21d8), storing logs in the user log directory without configurable N. | |
| #105 charmcraft-log files in /tmp | charmcraft | closed | Closed without a Charmcraft fix after pytest retention was blamed; follow-up identified the directories as Charmcraft logs, but received no response. | |
| #140 Always log the charmcraft version when indicated. | charmcraft | merged | Merged PR #140 as commit 65044e39, moving version logging to MessageHandler so it always reaches the log file and appears in verbose terminal output; partially addressed #48. |