← Back to issue list

fix the action generated by 'charmcraft init'

View original Github issue

Metadata

Project
charmcraft
Number
#142
Type
pull request
State
merged
Author
chipaca
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for the action generated by charmcraft init, resolving issue #141. Approved by three reviewers and verified by the reporter. Corrects a generation bug in the init command.

Suggested action:

No scores available.

Issue body

Whooops. Fixes: #141 Thanks to @narindergupta for bringing this to our attention.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for the action generated by charmcraft init, resolving issue #141. Approved by three reviewers and verified by the reporter. Corrects a generation bug in the init command.
qwen3.6-35b-a3b-mtp-q6 Merged a fix correcting action generation in charmcraft init, resolving issue #141. Authored by chipaca and verified by narindergupta before integration.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for an incorrectly generated action in charmcraft init, resolving issue #141. Submitted by chipaca and verified by narindergupta.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1114 config: support use actions in charmcraft.yaml charmcraft merged Merged update allowing actions in charmcraft.yaml instead of separate actions.yaml. Includes refactoring to fix circular imports. Approved by one reviewer across 10 files with 345 additions and 3 deletions.
76%
#36 'charmcraft build' should pull in actions.yaml and config.yaml charmcraft merged Merged after two reviewer approvals. The pull request implements automatic inclusion of actions.yaml and config.yaml during charmcraft builds, adding 80 lines across two files. Changes were successfully integrated.
75%
#238 `charmcraft init` creates broken charm charmcraft closed Superseded by PR #247, which overhauls charmcraft init and its tests to prevent broken charm generation from commented-out actions. The new implementation resolves the template and test failures.
75%
#91 First pass at 'charmcraft init' charmcraft merged Merged the initial 'charmcraft init' implementation. Approved by two reviewers, the PR adds 1087 lines across 24 files to scaffold charms. README.md, additional options, and interactive prompts require future updates.
75%
#289 fix: fix issues found in common.mk with charmcraft starbase merged Merged a fix for charmcraft issues in common.mk. Approved by two reviewers with zero unresolved comments. Changed two files, adding 11 and removing 7 lines.
73%
#31 feat: charmcraft actions craft-actions merged Merged changes adding two GitHub Actions: charmcraft/setup installs Charmcraft and LXD, while charmcraft/pack builds charms. Approved by two reviewers with passing CI checks, the update adds 299 lines across six files to streamline workflows.
73%
#1619 fix: use charmcraft package version charmcraft merged Merged after approval from two reviewers. Implements a one-line fix to use the charmcraft package version, updating a single file to resolve the versioning configuration.
73%
#49 ci: test the charmcraft actions in more places craft-actions merged Merged after two approvals and passing all CI checks. The update expands the continuous integration pipeline to test charmcraft actions across additional build environments, modifying a single file with minor configuration changes.
73%
#35 charmcraft doesn't support actions charmcraft closed Resolved by PR #36, which updated charmcraft to correctly copy actions.yaml into packaged charms, fixing the AttributeError when using the ops framework.
72%
#197 `charmcraft init` should not populate actions.yaml with real data charmcraft closed Closed without resolution. The report that charmcraft init populates config.yaml and actions.yaml with real YAML, risking accidental Charmhub uploads, was abandoned due to inactivity. No fix was implemented.
72%