← Back to issue list

Charm upload/release spread test is flaky

View original Github issue

Metadata

Project
charmcraft
Number
#1469
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Fixed the flaky store spread test by waiting and retrying release checks; merged in canonical/charmcraft#1460 (fd5bd6ba).

Resolution: closed resolved

Reason: PR #1460, commit fd5bd6ba, made the store spread test less flaky by delaying and retrying the channel-map validation while the store processes the release.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### Bug Description If the store is busy, this test will fail because it checks the edge channel before the store has completed the release. ### To Reproduce Hard to reproduce repeatedly, but when the staging store is busy run the charm-upload-and-release spread test ### Environment n/a ### charmcraft.yaml ```shell n/a ``` ### Relevant log output ```shell 2024-01-05 02:17:24 Error executing google:ubuntu-22.04-64:tests/spread/store/charm-upload-and-release (jan050211-981476) : Revision wasn't released. Uploaded revision: 1637; Currently on edge: 1636 2024-01-05 02:17:24 Restoring google:ubuntu-22.04-64:tests/spread/store/charm-upload-and-release (jan050211-981476)... 2024-01-05 02:17:27 Restoring google:ubuntu-22.04-64:tests/spread/store/ (jan050211-981476)... 2024-01-05 02:17:36 Discarding google:ubuntu-22.04-64 (jan050211-981476)... error: unsuccessful run 2024-01-05 02:17:37 Successful tasks: 6 2024-01-05 02:17:37 Aborted tasks: 0 2024-01-05 02:17:37 Failed tasks: 1 - google:ubuntu-22.04-64:tests/spread/store/charm-upload-and-release Error: Process completed with exit code 1. ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed the flaky store spread test by waiting and retrying release checks; merged in canonical/charmcraft#1460 (fd5bd6ba).
stealth/space-bunny-alpha — closed resolved Fixed the flaky charm upload/release spread test in PR #1460 (commit fd5bd6ba), making store spread tests less timing-sensitive.
qwen3.6-35b-a3b-mtp-q6 — — Closed without resolution. The flaky charm upload/release spread test, failing due to race conditions during store releases, was abandoned. No fix or workaround was implemented.
qwen/qwen3.6-35b-a3b — — Closed without comments or documented resolution. No fix or merge was implemented, indicating the flaky charm upload/release spread test was abandoned or resolved externally.
qwen/qwen3.6-35b-a3b — — Closed without a fix or resolution. No comments or linked pull requests were added, indicating the flaky charm upload/release spread test was likely abandoned due to the intermittent race condition when the store is busy.
qwen3.6-35b-a3b-mtp-q6 — — The flaky charm upload/release spread test was closed without resolution. No fix was implemented, indicating the issue was abandoned due to inactivity.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#1460 (confidence 100%)

    Commit fd5bd6ba merged the test fix titled "make store spread tests less flaky".

Related issues

Issue Project State Summary Similarity
#1429 spread: charm upload and release store test is flaky when the store is busy charmcraft closed Fixed in merged PR #1460 (commit fd5bd6ba), which reduced timing sensitivity in store upload and release Spread tests.
85%
#1218 tests: store resources spread test is flaky charmcraft closed Flaky store resources spread test was fixed by merged PR canonical/charmcraft#1223 in commit 35993996.
81%
#1362 CI: `charm-upload-and-release` test is flaky charmcraft closed Added propagation delays and status retries in PR #1366 (commit 05b18a03); later store-test hardening landed in PR #1460 (fd5bd6ba).
80%
#2426 fix(test): fix the reactive charm spread test charmcraft merged Merged in canonical/charmcraft#2426 via commit 7c33dd1b, applying a one-line fix to the reactive-charm spread test for CHARMCRAFT-641.
77%
#1214 tests: add more charms to large spread tests charmcraft closed Closed unmerged after 1,135 days; its large-spread test expansion landed through merged PR canonical/charmcraft#1217 in commit 0f4591a9.
75%
#1427 tests(spread): make dependencies restore work even if no charm is built charmcraft merged Merged in canonical/charmcraft#1427 (commit 2d432044), making spread-test dependency restoration work when no charm artifact is built.
74%
#1262 Bundle spread tests are failing charmcraft closed Bundle spread tests were fixed by merged PR #1287 (commit f60186ce), which validated YAML semantically and removed an obsolete charm-path assertion.
74%
#1324 test(spread): test-deploy charms in large spread tests charmcraft merged Merged PR #1324 via commit a14d6d91, adding test deployment of charms and bundles to large Spread tests.
73%
#1292 test(spread): make library tests register/unregister charms charmcraft merged Merged #1292 in commit 99a5a505, making library spread tests register and unregister charms and fixing store-timeout failures in #1279.
73%
#2032 ci: fixes to several weekly spread tests charmcraft merged Merged PR canonical/charmcraft#2032 as commit 29cb07f3, applying a first pass of fixes to several weekly Spread tests.
72%