← Back to issue list

refactor: move parts plugins to their own module

View original Github issue

Metadata

Project
charmcraft
Number
#1897
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1897 (commit 392f859b), separating craft-parts plugins into charmcraft/parts/plugins and isolating them from other parts functionality.

Resolution: closed resolved

Reason: PR #1897 was merged with two approvals and no unresolved review comments. Commit 392f859b records the completed module refactor.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This separates parts plugins from other things we do with craft-parts.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1897 (commit 392f859b), separating craft-parts plugins into charmcraft/parts/plugins and isolating them from other parts functionality.
stealth/space-bunny-alpha — closed resolved Merged the craft-parts refactor separating parts plugins from other functionality; approved by two reviewers with no unresolved comments.
qwen/qwen3.6-35b-a3b — — Merged a refactor by maintainer lengau that relocates parts plugins to a dedicated module, decoupling them from craft-parts. Approved by two reviewers, modifying 11 files (+72/-37).
qwen3.6-35b-a3b-mtp-q6 — — Merged refactoring that moves parts plugins into a dedicated module, separating them from other craft-parts functionality. Approved and integrated by maintainer lengau.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1334 refactor(parts): move craft-parts related things into their own package charmcraft merged Merged PR #1334, moving craft-parts code from charmcraft/parts.py into a dedicated package with plugins and lifecycle logic split into separate modules.
86%
#993 refactor: Move charm library helper functions to their own modules (CRAFT-1557) charmcraft merged Merged PR #993 refactored CRAFT-1557 by moving charm-library helpers into dedicated modules; implementation fb913b8f, merge 8d23a91c.
76%
#458 build: integrate craft-parts lifecycle (CRAFT-89, CRAFT-367, CRAFT-357) charmcraft merged Merged PR #458 via 9dc20872 (implementation 437dab55), adding a craft-parts lifecycle and charm build plugin to run the charm builder.
72%
#184 plugins: cmake craft-parts merged Merged the CMake plugin port into craft-parts via PR #184, merge commit 57744f7a, with implementation commit 9ceb1fc8.
71%
#525 parts: execute lifecycle from the project dir (CRAFT-505) charmcraft merged Merged in canonical/charmcraft#525 via 0d78f540, running the parts lifecycle from the project directory so relative plugin sources resolve when Charmcraft is launched elsewhere.
71%
#1549 refactor: use the official means to register plugins charmcraft merged Merged #1549 as commit 24da95e4, replacing custom plugin registration with craft-parts' official plugin registration mechanism.
71%
#249 fix: rename plugin to plugin_name craft-parts merged Merged canonical/craft-parts#249 via d5ed9639 (merge d53bed65), renaming the string-valued plugin variable to plugin_name across five files before #250.
70%