← Back to issue list

refactor: move parts plugins to their own module

View original Github issue

Metadata

Project
charmcraft
Number
#1897
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a refactor by maintainer lengau that relocates parts plugins to a dedicated module, decoupling them from craft-parts. Approved by two reviewers, modifying 11 files (+72/-37).

Suggested action:

No scores available.

Issue body

This separates parts plugins from other things we do with craft-parts.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a refactor by maintainer lengau that relocates parts plugins to a dedicated module, decoupling them from craft-parts. Approved by two reviewers, modifying 11 files (+72/-37).
qwen3.6-35b-a3b-mtp-q6 Merged refactoring that moves parts plugins into a dedicated module, separating them from other craft-parts functionality. Approved and integrated by maintainer lengau.
qwen3.6-35b-a3b-mtp-q6 Merged a refactoring change that moves parts plugins into a dedicated module, separating them from other craft-parts functionality. Integrated directly without additional comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1334 refactor(parts): move craft-parts related things into their own package charmcraft merged Merged a refactor that moves craft-parts components into a dedicated package. Approved by two reviewers with zero unresolved comments. The change modifies 16 files, adding 960 lines and removing 794.
82%
#515 refactor(docs): use more docs from craft-parts rockcraft merged Merged a documentation refactor simplifying the repository by directly referencing or embedding shared craft-parts docs. Approved by two reviewers, the update modifies 19 files, adding 61 and removing 38 lines.
76%
#4679 refactor(docs): use more docs from craft-parts snapcraft merged Merged documentation refactor replacing duplicated content with direct references or includes from shared craft-parts docs. Approved by two reviewers, passed CI, modified 18 files, and maintained 100% test coverage on changed lines.
76%
#1549 refactor: use the official means to register plugins charmcraft merged Merged a maintainer-led refactor replacing custom plugin registration with the official API. The change modified one file (+6/-3 lines), received approval from two reviewers, and was successfully integrated into the main branch.
74%
#5205 refactor: use craft-platforms utilities snapcraft merged Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files.
74%
#993 refactor: Move charm library helper functions to their own modules (CRAFT-1557) charmcraft merged Merged refactoring extracting charm library helpers into dedicated modules, resolving CRAFT-1557. Approved by one reviewer with no unresolved comments. Modifies seven files, adding 658 lines and removing 587.
74%
#4682 refactor(app): use more code from craft-app snapcraft merged Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines.
73%
#3636 parts: integrate craft-parts (CRAFT-765) snapcraft merged Merged after reviewer approval and passing CI checks. Integrates craft-parts for part validation and lifecycle processing. Modifies 12 files, adding 369 lines and removing 20, fulfilling CRAFT-765.
72%
#1548 refactor: move manifest generation logic into package service charmcraft merged Merged maintainer lengau's refactor moving manifest generation logic to the package service. Approved by two reviewers with zero unresolved comments. Changes span five files, adding 72 lines and removing 87.
71%
#1507 many: simplify plugin loading snapcraft merged Merged an architectural refactor that simplifies plugin loading by shifting initialization from PluginHandler to PartsConfig. Approved by one reviewer across 13 files, the change decouples components and enables future grammar processing extraction.
70%