refactor(tests/spread): stop use init in most spread tests
Metadata
Current evaluation
Closed unmerged and replaced by PR #1556, merged as commit 4682b32b, which updated Spread tests to use explicit charmcraft.yaml files instead of charmcraft init.
Resolution: closed superseded
Reason: PR #1556 superseded this approach and was merged as commit 4682b32b. The author also commented that #1555's method was a bad way to perform the refactor.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This looks like a big PR, but it's mostly machine-generated and I'm including instructions to reproduce those changes so you can skip reviewing machine-generated files.
# Recommended review process:
0. Check this out locally
1. In each charm directory added, delete all files and run `charmcraft init --author=Canonical --profile=` with the appropriate profile (`simple` unless the charm name includes `kubernetes` or `machine`)
2. Compare the related `task.yaml` file to ensure that the changes correspond to the differences between what `charmcraft init` created and what exists in the directory. (NOTE: Most of these charms don't include the whole template, so `git status` will show a bunch of new files that you can discard.)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged and replaced by PR #1556, merged as commit 4682b32b, which updated Spread tests to use explicit charmcraft.yaml files instead of charmcraft init. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; its explicit charmcraft.yaml test refactor was superseded by merged PR #1556 (commit 4682b32b). | |
| stealth/space-bunny-alpha | — | closed stale | PR #1555 was closed unmerged after its maintainer called the approach "a bad way to do this" on 2024-02-28. | |
| qwen/qwen3.6-35b-a3b | — | — | Author closed and abandoned the changes after self-review deemed the approach flawed. No code was merged or reviewed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Author closed and abandoned the pull request after determining that replacing spread test initialization with charmcraft init was flawed. No changes were merged. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/charmcraft#1556
(confidence 99%)
Merged replacement refactoring Spread tests around explicit charmcraft.yaml files.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1556 refactor(tests/spread): test with explicit charmcraft.yaml files | charmcraft | merged | Merged PR #1556 in commit 4682b32b, replacing prepare-step manipulation of charmcraft.yaml with explicit spread-test configuration files. | |
| #665 Start using `spread` for integration tests | charmcraft | closed | Adopted spread for integration tests via merged PR canonical/charmcraft#862 (merge commit 7790c044, branch spread-bootstrap). Issue closed by maintainer sergiusens on 2023-03-16 noting the work was done in that PR. | |
| #1514 feat(testing): add spread testing template files | charmcraft | closed | Closed unmerged as superseded by #1660 (commit 097a4e9a), which added charmcraft test and Spread templates, plus merged follow-up #1686 (58d36668). | |
| #2118 fix: remove experimental spread init templates | charmcraft | merged | Merged #2118 as commit 73ed7267, removing experimental spread templates from charmcraft init while leaving existing generated spread files working. | |
| #1325 test(spread): consolidate basic init/build tests | charmcraft | merged | Merged PR #1325 as commit 90e25caf, consolidating basic Spread init/build tests for CRAFT-2127 and reducing duplicated setup across four files. | |
| #1438 refactor(tests): update weekly spread for real-world changes | charmcraft | closed | Closed unmerged after 920 days of inactivity; charmcraft#1438's tox compatibility changes and two additional weekly-spread charm cases never landed. | |
| #291 Refactor spread testing to use spread extensions | fetch-service | closed | Fixed by merged PR #299 (commit 44d9906), which refactored spread tests to generate spread.yaml and use the new spread extension framework. | |
| #2032 ci: fixes to several weekly spread tests | charmcraft | merged | Merged PR canonical/charmcraft#2032 as commit 29cb07f3, applying a first pass of fixes to several weekly Spread tests. | |
| #1266 tests(spread): requirements dependencies | charmcraft | merged | Merged PR #1266 at 97d95b39, adding spread tests for requirements-file and charm-dependency combinations; the PR explicitly fixes #1179. | |
| #1214 tests: add more charms to large spread tests | charmcraft | closed | Closed unmerged after 1,135 days; its large-spread test expansion landed through merged PR canonical/charmcraft#1217 in commit 0f4591a9. |