refactor(tests/spread): stop use init in most spread tests
Metadata
Current evaluation
Author closed and abandoned the changes after self-review deemed the approach flawed. No code was merged or reviewed.
Suggested action: —
No scores available.
Issue body
This looks like a big PR, but it's mostly machine-generated and I'm including instructions to reproduce those changes so you can skip reviewing machine-generated files.
# Recommended review process:
0. Check this out locally
1. In each charm directory added, delete all files and run `charmcraft init --author=Canonical --profile=` with the appropriate profile (`simple` unless the charm name includes `kubernetes` or `machine`)
2. Compare the related `task.yaml` file to ensure that the changes correspond to the differences between what `charmcraft init` created and what exists in the directory. (NOTE: Most of these charms don't include the whole template, so `git status` will show a bunch of new files that you can discard.)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Author closed and abandoned the changes after self-review deemed the approach flawed. No code was merged or reviewed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Author closed and abandoned the pull request after determining that replacing spread test initialization with charmcraft init was flawed. No changes were merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Abandoned by author who determined the charmcraft init approach for spread tests was flawed. Changes were not merged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6197 test(spread): debug spread failures 2 | snapcraft | closed | Closed without merging. The author reproduced the failing spread tests in pull request #6198, making this debugging effort redundant and abandoned. | |
| #2763 fix(tests/spread): fix reactive spread tests | charmcraft | merged | Merged after resolving failing reactive spread tests. The changes split the test suite into legacy and resolute variants, switched to binary wheels to fix dependency resolution, and removed obsolete flags. Approved by reviewers and integrated. | |
| #291 Refactor spread testing to use spread extensions | fetch-service | closed | Abandoned. The request to refactor spread testing was synced to internal Jira ticket CRAFT-3690 and closed without implementation. No code changes or resolution were provided. | |
| #665 Start using `spread` for integration tests | charmcraft | closed | Completed and merged via pull request #862, which implemented the spread infrastructure and added integration tests. The issue was closed after the changes were successfully integrated. | |
| #6198 test(spread): add missing symlink | snapcraft | closed | Abandoned. The change added a test reproducing a spread panic on dangling symlinks but failed integration checks. Without reviewer approval or CI success, the contribution was closed without merging. | |
| #299 refactor(spread): prototype spread extension | fetch-service | merged | Merged after two approvals. Refactored test suites to use the spread extension mechanism, dynamically generating spread.yaml before execution. Resolves #291. Modified 14 files, +325/-317 lines. | |
| #12 Craft 2382 more spread tests | snapcraft-rocks | closed | Closed without merge. The PR added 234 lines of spread tests across 18 files but received zero reviews, CI checks, or comments. It was abandoned 922 days ago. | |
| #3480 ci: spread testing | snapcraft | closed | Closed without merging. The maintainer submitted the pull request as a temporary test, requested it be ignored, and abandoned it without review or CI checks. | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks. | |
| #1290 test(spread): clean up store tests | charmcraft | merged | Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers. |