← Back to issue list

feat(testing): add spread testing template files

View original Github issue

Metadata

Project
charmcraft
Number
#1514
Type
pull request
State
closed
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged as superseded by #1660 (commit 097a4e9a), which added charmcraft test and Spread templates, plus merged follow-up #1686 (58d36668).

Resolution: closed superseded

Reason: The author explicitly identified #1660 and #1686 as superseding work. PR #1660 merged the replacement test command and templates, while #1686 merged argument-handling fixes.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add Jinja2 template files for machine charm testing, installed when initializing a minimal charm with `charmcraft init --profile machine`. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded by #1660 (commit 097a4e9a), which added charmcraft test and Spread templates, plus merged follow-up #1686 (58d36668).
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded by #1660, which added charmcraft test and Spread templates in commit 097a4e9a, with argument parsing fixed by #1686 in commit 58d36668.
stealth/space-bunny-alpha — closed superseded Spread template proposal was superseded by the test command implementation in PR #1660 and follow-up argument fixes in PR #1686, both merged.
qwen/qwen3.6-35b-a3b — — Adds Jinja2 template files for machine charm spread testing. After reviewers requested changes and left unresolved comments, the work was closed and superseded by pull requests #1660 and #1686.
qwen3.6-35b-a3b-mtp-q6 — — Added Jinja2 templates for machine charm testing. The pull request was closed and superseded by PRs #1660 and #1686.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/charmcraft#1660 (confidence 100%)

    Merged as 097a4e9a; added charmcraft test with local or remote Spread suite templates.

  • Superseded By: canonical/charmcraft#1686 (confidence 100%)

    Merged as 58d36668; follow-up fixing test command argument parsing and long-option handling.

Related issues

Issue Project State Summary Similarity
#1555 refactor(tests/spread): stop use init in most spread tests charmcraft closed Closed unmerged and replaced by PR #1556, merged as commit 4682b32b, which updated Spread tests to use explicit charmcraft.yaml files instead of charmcraft init.
79%
#16 tests: add spread support rockcraft merged Merged PR #16 added Spread support for CRAFT-865 via commit 3aeba2b3 (merge commit 5bf2680a).
76%
#1214 tests: add more charms to large spread tests charmcraft closed Closed unmerged after 1,135 days; its large-spread test expansion landed through merged PR canonical/charmcraft#1217 in commit 0f4591a9.
76%
#1660 feat: add test command and templates charmcraft merged Merged as commit 097a4e9a, adding `charmcraft test` with templates for local or remote Spread suites using a Multipass backend.
76%
#1556 refactor(tests/spread): test with explicit charmcraft.yaml files charmcraft merged Merged PR #1556 in commit 4682b32b, replacing prepare-step manipulation of charmcraft.yaml with explicit spread-test configuration files.
76%
#1325 test(spread): consolidate basic init/build tests charmcraft merged Merged PR #1325 as commit 90e25caf, consolidating basic Spread init/build tests for CRAFT-2127 and reducing duplicated setup across four files.
75%
#1382 test: use MATCH in spread tests charmcraft merged Merged in charmcraft#1382 (commit 90f23622), replacing grep assertions with MATCH in four spread-test files so missing expected output correctly fails tests.
75%
#13 test(spread): add more spread tests snapcraft-rocks merged Merged PR #13 added Spread tests for architectures, Chisel slices, craftctl, package repositories, and patchelf (+206/-5 across 15 files).
75%
#2118 fix: remove experimental spread init templates charmcraft merged Merged #2118 as commit 73ed7267, removing experimental spread templates from charmcraft init while leaving existing generated spread files working.
74%
#1266 tests(spread): requirements dependencies charmcraft merged Merged PR #1266 at 97d95b39, adding spread tests for requirements-file and charm-dependency combinations; the PR explicitly fixes #1179.
74%