← Back to issue list

refactor(tests/spread): test with explicit charmcraft.yaml files

View original Github issue

Metadata

Project
charmcraft
Number
#1556
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1556 in commit 4682b32b, replacing prepare-step manipulation of charmcraft.yaml with explicit spread-test configuration files.

Resolution: closed resolved

Reason: PR #1556 was approved and merged as commit 4682b32b. The refactor simplified spread-test setup ahead of adding more charmcraft.yaml variants.

Evaluated by: mr-cal-bot

No scores available.

Issue body

We're about to have a lot more variants of `charmcraft.yaml` to spread test. This makes it far more straightforward than trying to manipulate charmcraft.yaml during the prepare step.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1556 in commit 4682b32b, replacing prepare-step manipulation of charmcraft.yaml with explicit spread-test configuration files.
stealth/space-bunny-alpha — closed resolved Merged PR #1556 in commit 4682b32b, replacing prepare-step manipulation of charmcraft.yaml with explicit test configuration files for easier spread-test coverage.
qwen/qwen3.6-35b-a3b — — Merged a refactor replacing dynamic charmcraft.yaml manipulation during the prepare step with explicit configuration files. Approved by three reviewers, the change simplifies testing for upcoming variants across nine modified files.
qwen3.6-35b-a3b-mtp-q6 — — Merged refactoring of spread tests to use explicit charmcraft.yaml files instead of runtime manipulation. This simplifies testing for upcoming configuration variants.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1555 refactor(tests/spread): stop use init in most spread tests charmcraft closed Closed unmerged and replaced by PR #1556, merged as commit 4682b32b, which updated Spread tests to use explicit charmcraft.yaml files instead of charmcraft init.
87%
#2426 fix(test): fix the reactive charm spread test charmcraft merged Merged in canonical/charmcraft#2426 via commit 7c33dd1b, applying a one-line fix to the reactive-charm spread test for CHARMCRAFT-641.
77%
#1287 fix(tests): fixes bundle spread test charmcraft merged Merged PR #1287 (commit f60186ce, CRAFT-2052) fixed the failing bundle spread test by validating YAML with Python and dropping a non-working charm path check, resolving #1262.
76%
#1266 tests(spread): requirements dependencies charmcraft merged Merged PR #1266 at 97d95b39, adding spread tests for requirements-file and charm-dependency combinations; the PR explicitly fixes #1179.
76%
#1324 test(spread): test-deploy charms in large spread tests charmcraft merged Merged PR #1324 via commit a14d6d91, adding test deployment of charms and bundles to large Spread tests.
76%
#1514 feat(testing): add spread testing template files charmcraft closed Closed unmerged as superseded by #1660 (commit 097a4e9a), which added charmcraft test and Spread templates, plus merged follow-up #1686 (58d36668).
76%
#1427 tests(spread): make dependencies restore work even if no charm is built charmcraft merged Merged in canonical/charmcraft#1427 (commit 2d432044), making spread-test dependency restoration work when no charm artifact is built.
75%
#1660 feat: add test command and templates charmcraft merged Merged as commit 097a4e9a, adding `charmcraft test` with templates for local or remote Spread suites using a Multipass backend.
74%
#665 Start using `spread` for integration tests charmcraft closed Adopted spread for integration tests via merged PR canonical/charmcraft#862 (merge commit 7790c044, branch spread-bootstrap). Issue closed by maintainer sergiusens on 2023-03-16 noting the work was done in that PR.
74%
#2118 fix: remove experimental spread init templates charmcraft merged Merged #2118 as commit 73ed7267, removing experimental spread templates from charmcraft init while leaving existing generated spread files working.
74%