← Back to issue list

refactor(tests/spread): test with explicit charmcraft.yaml files

View original Github issue

Metadata

Project
charmcraft
Number
#1556
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a refactor replacing dynamic charmcraft.yaml manipulation during the prepare step with explicit configuration files. Approved by three reviewers, the change simplifies testing for upcoming variants across nine modified files.

Suggested action:

No scores available.

Issue body

We're about to have a lot more variants of `charmcraft.yaml` to spread test. This makes it far more straightforward than trying to manipulate charmcraft.yaml during the prepare step.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a refactor replacing dynamic charmcraft.yaml manipulation during the prepare step with explicit configuration files. Approved by three reviewers, the change simplifies testing for upcoming variants across nine modified files.
qwen3.6-35b-a3b-mtp-q6 Merged refactoring of spread tests to use explicit charmcraft.yaml files instead of runtime manipulation. This simplifies testing for upcoming configuration variants.
qwen3.6-35b-a3b-mtp-q6 Merged a refactoring of spread tests to use explicit charmcraft.yaml files instead of manipulating them during the prepare step, simplifying future testing of multiple configuration variants.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2426 fix(test): fix the reactive charm spread test charmcraft merged Merged a one-line fix for the reactive charm spread test. Approved by two reviewers and passed CI checks. Resolves CHARMCRAFT-641.
76%
#1622 fix: reorganise charmcraft.yaml preprocessing charmcraft merged Merged following two approvals and passing CI. Reorganized charmcraft.yaml preprocessing to apply extensions on raw data, assign default parts to charms with bases, and enforce dictionary type for parts. Modified 5 files (+27/-14 lines).
76%
#1287 fix(tests): fixes bundle spread test charmcraft merged Merged. Resolves issue #1262 and CRAFT-2052 by fixing the bundle spread test. Replaced a failing charm path check with Python-based YAML validation. Approved by two reviewers, passed CI, and successfully executed the large spread test.
75%
#1660 feat: add test command and templates charmcraft merged Merged addition of the charmcraft test command and templates. The feature invokes spread to run test suites locally and remotely using a multipass backend. Approved by two reviewers and rebased on main before integration.
75%
#1324 test(spread): test-deploy charms in large spread tests charmcraft merged Merged to add test deployment for charms and bundles in large spread tests. Approved by two reviewers, modified six files with 85 additions and 26 deletions, and linked to a passing CI run.
74%
#1198 tests: add charm library multiple versions update test charmcraft merged Merged after approval, adding a test for updating charm library multiple versions. The change introduces 120 lines to address CRAFT-1916 and issue #1020, with zero unresolved review comments.
73%
#2154 docs: replace occurrences of "charmcraft.yaml" and "recipe" charmcraft merged Merged documentation update replacing charmcraft.yaml and recipe with project or project file across 23 files. Approved by two reviewers after minor clarity feedback. Changes span +155/-159 lines.
73%
#397 feat: add charmcraft inspector fetch-service merged Merged the charmcraft inspector, verifying charmcraft.yaml existence. Approved by two reviewers, passed CI, and changed 7 files. The author addressed invocation order review comments prior to final merge.
72%
#1357 refactor: reorganise constants charmcraft merged Merged a refactor reorganizing constants for Charmcraft environment variables, project filenames, and output files/directories across 47 files. Changes include 471 additions and 443 deletions. Approved by four reviewers with no unresolved comments.
72%
#49 ci: test the charmcraft actions in more places craft-actions merged Merged after two approvals and passing all CI checks. The update expands the continuous integration pipeline to test charmcraft actions across additional build environments, modifying a single file with minor configuration changes.
71%