← Back to issue list

fix: add default charm part in flask-framework

View original Github issue

Metadata

Project
charmcraft
Number
#1620
Type
pull request
State
merged
Author
weiiwang01
Labels
Created
Updated
Closed

Current evaluation

Merged PR adds the default charm part to the flask-framework extension and prevents conflicts with custom configurations. Template dependencies were updated to fix sdist builds, resolving issue #1616.

Suggested action:

No scores available.

Issue body

As charmcraft will not automatically add the default `charm` part if extensions are in use, the `flask-framework` extension should include the charm part. Furthermore, as the `flask-framework` extension is designed exclusively for `ops` based charms, it should incorporate a check to ensure that there is no customized charm part in `charmcraft.yaml` that could potentially conflict with the extension. Some miscellaneous changes include the use of new library packages in the template `requirements.txt`. Fix: https://github.com/canonical/charmcraft/issues/1616

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged PR adds the default charm part to the flask-framework extension and prevents conflicts with custom configurations. Template dependencies were updated to fix sdist builds, resolving issue #1616.
qwen3.6-35b-a3b-mtp-q6 Merged update adds the default charm part to the flask-framework extension and checks for conflicting custom charm parts. Updated requirements and paas-app-charmer dependency per reviewer feedback to resolve sdist build issues, fixing #1616.
qwen3.6-35b-a3b-mtp-q6 Merged. Added a default charm part to the flask-framework extension and a conflict check for customized parts. Updated template requirements and resolved sdist compatibility by adjusting the paas-app-charmer dependency per reviewer feedback. Fixes #1616.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2556 fix: charmcraft templates for flask and django extensions charmcraft merged Merged external contribution adding the missing platforms key to charmcraft.yaml templates for Flask and Django 12-factor extensions. Approved by two reviewers, passed CI checks, and updated documentation.
74%
#1428 Add init template for flask-framework charmcraft merged Merged an external contribution adding a flask-framework profile to the charmcraft init command. The template scaffolds basic 12-factor Flask charms, omitting tests and tox.ini for standard project root placement. Approved by three reviewers.
72%
#1257 Add the flask extension charmcraft merged Merged an experimental Flask extension for charmcraft's Juju 12-factor charm ecosystem. Approved by two reviewers and integrated after incorporating sprint demo updates and addressing testing requirements.
72%
#1718 Flask extension. Allow charm-libs to be extended by the user charmcraft merged Merged. Resolves Flask extension AttributeError when charm-libs is pre-defined in charmcraft.yaml. Combines and deduplicates charm-libs from both extension and user configs. Approved and passed CI.
71%