← Back to issue list

fix: add default charm part in flask-framework

View original Github issue

Metadata

Project
charmcraft
Number
#1620
Type
pull request
State
merged
Author
weiiwang01
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1620 added a default ops charm part and conflict check to flask-framework, updated template dependencies, and addressed #1616.

Resolution: closed resolved

Reason: PR #1620 was approved and merged, explicitly fixing #1616 by making flask-framework define its own charm part and reject conflicting custom definitions. The broader default-part issue was later also resolved by PR #1815, commit 2a0eb973.

Evaluated by: mr-cal-bot

No scores available.

Issue body

As charmcraft will not automatically add the default `charm` part if extensions are in use, the `flask-framework` extension should include the charm part. Furthermore, as the `flask-framework` extension is designed exclusively for `ops` based charms, it should incorporate a check to ensure that there is no customized charm part in `charmcraft.yaml` that could potentially conflict with the extension. Some miscellaneous changes include the use of new library packages in the template `requirements.txt`. Fix: https://github.com/canonical/charmcraft/issues/1616

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1620 added a default ops charm part and conflict check to flask-framework, updated template dependencies, and addressed #1616.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#1620, adding the default charm part and a custom-part conflict check to flask-framework; fixes #1616 for this extension.
qwen/qwen3.6-35b-a3b — — Merged PR adds the default charm part to the flask-framework extension and prevents conflicts with custom configurations. Template dependencies were updated to fix sdist builds, resolving issue #1616.
qwen3.6-35b-a3b-mtp-q6 — — Merged update adds the default charm part to the flask-framework extension and checks for conflicting custom charm parts. Updated requirements and paas-app-charmer dependency per reviewer feedback to resolve sdist build issues, fixing #1616.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#1616 (confidence 100%)

    PR #1620 explicitly links the missing flask-framework charm-part behavior to this issue.

  • Likely Fixed By: canonical/charmcraft#1815 (confidence 90%)

    Issue #1616 records this later merged PR and commit 2a0eb973 as the general fix for default charm or bundle part handling.

Related issues

Issue Project State Summary Similarity
#2556 fix: charmcraft templates for flask and django extensions charmcraft merged Merged #2556 added the missing platforms key to Charmcraft YAML templates for Flask and Django 12-factor extensions.
72%
#1428 Add init template for flask-framework charmcraft merged PR #1428 was merged, adding the flask-framework profile and basic init template for 12-factor Flask charms.
72%
#1747 Failed to run the build script for part 'charm' charmcraft closed Flask-framework packing was fixed by merged PR #1751 (commit 40beeef3), which added a default Rust version. The fix shipped in Charmcraft 3.1.0.
71%