tests: fix the pip check integration test
Metadata
Current evaluation
Merged after two approvals, fixing the pip check integration test that was incorrectly passing. The change updated one file to correct the test logic.
Suggested action: —
No scores available.
Issue body
As pointed out here: https://github.com/canonical/charmcraft/pull/1794#discussion_r1706033423
It was succeeding when it should have failed
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after two approvals, fixing the pip check integration test that was incorrectly passing. The change updated one file to correct the test logic. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the pip check integration test that was incorrectly passing. The update corrects the test logic to properly fail when expected, resolving the issue highlighted in PR #1794. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the pip check integration test that was incorrectly passing. The test assertions were corrected to properly fail when expected, resolving the false positive. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5375 test: fix command tests | snapcraft | merged | Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions. | |
| #57 tests: update pylint and address new warnings | craft-parts | merged | Merged after two approvals and passing CI. Updated pylint to 2.8.2 and resolved newly introduced linting warnings in the test suite with minor code adjustments across a single file. | |
| #1910 ci: fix tics tests | charmcraft | merged | Merged a single-file update to fix TICS CI tests. Approved by two reviewers with no unresolved comments. The change resolves failing continuous integration checks. | |
| #1398 tests: fix issues with python 3.6 | snapcraft | merged | Merged fix for Python 3.6 test compatibility. Approved by one reviewer, modified three files (+34/-7). Resolves Launchpad bug #1699009. | |
| #1245 tests: add parallel build test | charmcraft | merged | Merged after three approvals. Added a parallel build test to resolve issue #1138, modifying three files with 44 additions and 2 deletions. All checks passed and the change was integrated. | |
| #82 test: improve integration testing | craft-store | merged | Merged improvements to integration testing across eight files. The update works around external fork credential limitations by running full tests only after merging to main. Approved by one reviewer and passed CI. | |
| #392 plugins: fix pip path in python plugin | craft-parts | merged | Merged a fix ensuring the python plugin uses the venv pip path, preventing unintended package installations when PATH changes. Approved by one reviewer, passed CI checks, and modified five files. | |
| #1716 tests: split the integration autopkgtests | snapcraft | merged | Merged after splitting integration autopkgtests to eliminate timeout failures. The change adds minor per-test setup overhead but resolves recurring execution timeouts. Approved by two reviewers with passing CI checks. |