← Back to issue list

chore!: update to pydantic 2

View original Github issue

Metadata

Project
craft-grammar
Number
#36
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #36 (commit 06fc994), completing the breaking Pydantic 2 update after two approvals and manual confirmation of the author's CLA employment status.

Resolution: closed resolved

Reason: PR #36 was merged with two approvals as commit 06fc994. The maintainer manually confirmed the author was a Canonical employee and accepted the CLA-check exception.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #36 (commit 06fc994), completing the breaking Pydantic 2 update after two approvals and manual confirmation of the author's CLA employment status.
stealth/space-bunny-alpha — closed resolved Merged Pydantic 2 migration in canonical/craft-grammar#36, changing five files (+110/-52) with two approvals. The maintainer overrode the CLA failure after manually confirming the author’s employment.
qwen/qwen3.6-35b-a3b — — Merged the Pydantic 2 migration across five files. Approved by two reviewers and passed CI. The maintainer manually verified the author's Canonical employment to override an automated CLA check failure before finalizing the merge.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-grammar#35 (confidence 95%)

    Commit 6be0fc3 fixed the deprecated Pydantic validator API during the same migration effort.

  • Related To: canonical/craft-grammar#33 (confidence 90%)

    Earlier commit 5e225fb performed part of the Pydantic 2 migration.

Related issues

Issue Project State Summary Similarity
#33 chore!: update to Pydantic 2 craft-grammar merged Merged as commit 5e225fb via PR #33, updating craft-grammar to Pydantic 2 and revising grammar validation errors; fixes #32.
84%
#771 chore: lift-and-shift update to pydantic 2 craft-parts merged Merged PR #771 as commit 6b155294, completing phase 1 of the Pydantic 2 migration across 38 files using bump-pydantic and follow-up fixes.
82%
#112 chore(deps): update to pydantic 2 & bump-pydantic craft-archives closed Closed unmerged; its Pydantic 2 migration was superseded by #103 (b69f44a) and merged into main through #123.
81%
#1817 chore: merge pydantic 2 support to main charmcraft merged Pydantic 2 support was merged into main by PR #1817 (commit 394e6e55), completing the migration begun in #1777 across 52 files.
80%
#370 chore(deps): update dependency pydantic to v2 craft-providers closed Renovate pydantic v2 bump closed unmerged by mr-cal to defer migration to a larger craft effort; the upgrade later landed in merged PR #451 (commit f380a9e) for 2.0.
79%
#28 chore(deps): update dependency pydantic to v2 - autoclosed craft-grammar closed Renovate's Pydantic 2 bump was closed unmerged and superseded by dedicated migration PR #33, which landed in commit 5e225fb.
79%
#122 chore: eliminate pydantic warnings craft-archives merged Merged PR #122 eliminated Pydantic warnings, landing as commit 00b9b3b after approval by two reviewers.
79%
#408 chore!: merge pydantic 2 feature branch to main craft-application merged Merged into main via c3aae96c, making Pydantic 2 required and incorporating final typing fixes from 25ea79c; the change is explicitly breaking.
79%
#1351 chore(deps): update dependency pydantic to v2 charmcraft closed Renovate PR bumping pydantic 1.10.13 -> 2.4.2 was closed unmerged by lengau ("will need its own project"). The upgrade later landed via PR #1777 (70078b03), merged to main in #1817 (394e6e55).
78%
#778 chore: pydantic 2 related cleanup craft-parts merged Merged Pydantic 2 cleanup across seven files in commit 68d61fa0, following prerequisite plugin-model restructuring in #775.
78%