chore!: merge pydantic 2 feature branch to main
Metadata
Current evaluation
Merged into main via c3aae96c, making Pydantic 2 required and incorporating final typing fixes from 25ea79c; the change is explicitly breaking.
Resolution: closed resolved
Reason: PR #408 was approved with no unresolved review comments and merged as commit c3aae96c. It completed the Pydantic 2 migration and included the typing fixes from 25ea79c.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Breaking changes:
* Depends on pydantic 2
The main thing to check here is the most recent commit: https://github.com/canonical/craft-application/pull/408/commits/25ea79ccdb88bde2807032a43e197bfe55d7c88b
which fixes typing issues. Everything else is previously approved.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into main via c3aae96c, making Pydantic 2 required and incorporating final typing fixes from 25ea79c; the change is explicitly breaking. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged the Pydantic 2 migration in #408 via commit c3aae96c, making Pydantic 2 required and including typing fixes from 25ea79c. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged the pydantic 2 feature branch into main, upgrading the codebase and resolving typing issues. Approved by two reviewers and passing CI checks, the merge introduces breaking changes required for the pydantic 2 dependency update. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#401
(confidence 90%)
Earlier merged Pydantic 2 upgrade, committed as c2f0978a, preceded this final integration into main.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1817 chore: merge pydantic 2 support to main | charmcraft | merged | Pydantic 2 support was merged into main by PR #1817 (commit 394e6e55), completing the migration begun in #1777 across 52 files. | |
| #1807 chore: merge main to pydantic feature branch | charmcraft | closed | Closed unmerged after 771 days of inactivity. The Pydantic 2 branch-sync work later reached main through #1817 at commit 394e6e55. | |
| #123 chore!: merge branch 'feature/2.0' into 'main' | craft-archives | merged | Merged feature/2.0 into main in commit 15a1623, delivering Python 3.10+ support and Pydantic 2 requirements. | |
| #616 chore!: merge 2.0 feature branch to main | craft-providers | merged | Merged the 2.0 feature branch into main via PR #616 (commit b0b7a3e), removing deprecated APIs and requiring Python 3.10+ and pydantic 2. | |
| #112 chore(deps): update to pydantic 2 & bump-pydantic | craft-archives | closed | Closed unmerged; its Pydantic 2 migration was superseded by #103 (b69f44a) and merged into main through #123. | |
| #36 chore!: update to pydantic 2 | craft-grammar | merged | Merged PR #36 (commit 06fc994), completing the breaking Pydantic 2 update after two approvals and manual confirmation of the author's CLA employment status. | |
| #1351 chore(deps): update dependency pydantic to v2 | charmcraft | closed | Renovate PR bumping pydantic 1.10.13 -> 2.4.2 was closed unmerged by lengau ("will need its own project"). The upgrade later landed via PR #1777 (70078b03), merged to main in #1817 (394e6e55). | |
| #778 chore: pydantic 2 related cleanup | craft-parts | merged | Merged Pydantic 2 cleanup across seven files in commit 68d61fa0, following prerequisite plugin-model restructuring in #775. | |
| #370 chore(deps): update dependency pydantic to v2 | craft-providers | closed | Renovate pydantic v2 bump closed unmerged by mr-cal to defer migration to a larger craft effort; the upgrade later landed in merged PR #451 (commit f380a9e) for 2.0. | |
| #116 chore(deps): update dependency pydantic to v2 | craft-store | closed | Renovate's pydantic v2 bump PR was closed unmerged by @lengau (2023-10-22, "Pydantic 2 will need some significant changes"); the real migration landed later in merged PR #193 (commit 026b78d). |