← Back to issue list

chore!: merge pydantic 2 feature branch to main

View original Github issue

Metadata

Project
craft-application
Number
#408
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged the pydantic 2 feature branch into main, upgrading the codebase and resolving typing issues. Approved by two reviewers and passing CI checks, the merge introduces breaking changes required for the pydantic 2 dependency update.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? ----- Breaking changes: * Depends on pydantic 2 The main thing to check here is the most recent commit: https://github.com/canonical/craft-application/pull/408/commits/25ea79ccdb88bde2807032a43e197bfe55d7c88b which fixes typing issues. Everything else is previously approved.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the pydantic 2 feature branch into main, upgrading the codebase and resolving typing issues. Approved by two reviewers and passing CI checks, the merge introduces breaking changes required for the pydantic 2 dependency update.
qwen3.6-35b-a3b-mtp-q6 Merged the pydantic 2 feature branch into main, introducing a breaking dependency update. The merge incorporates previously approved changes and a final commit resolving typing issues.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1817 chore: merge pydantic 2 support to main charmcraft merged Merged pydantic 2 support into the main branch after approval from two reviewers. The update modifies 52 files, adding 2860 lines and removing 714, completing the dependency upgrade.
91%
#123 chore!: merge branch 'feature/2.0' into 'main' craft-archives merged Merged feature/2.0 into main, introducing breaking changes that require Python 3.10+ and Pydantic 2. Approved by two reviewers with all CI checks passing.
87%
#36 chore!: update to pydantic 2 craft-grammar merged Merged the Pydantic 2 migration across five files. Approved by two reviewers and passed CI. The maintainer manually verified the author's Canonical employment to override an automated CLA check failure before finalizing the merge.
84%
#195 chore!: merge 3.0 feature branch to main craft-store merged Merged the 3.0 feature branch into main following approval by two reviewers. The update enforces Python 3.10+ and Pydantic 2 as breaking changes, altering 32 files (+273/-244 lines).
83%
#4955 chore!: migrate to pydantic 2 snapcraft merged Merged after two approvals and passing CI. Migrates the codebase to Pydantic 2, resolving issue #4941. The author rebased and force-pushed clean commits prior to a rebase-merge.
83%
#33 chore!: update to Pydantic 2 craft-grammar merged Merged update to Pydantic 2. Resolves issue #32 by addressing breaking changes in grammar validation error messages. Approved by two reviewers, passed CI checks, and modified five files (+40/-41 lines).
83%
#771 chore: lift-and-shift update to pydantic 2 craft-parts merged Merged after two approvals and passing CI. The update migrates the codebase to Pydantic 2 using bump-pydantic and manual fixes. It touched 38 files (+207/-127 lines) as the initial phase of the broader dependency upgrade.
80%
#1807 chore: merge main to pydantic feature branch charmcraft closed Closed without merging. The pydantic feature branch synchronization received no reviews or CI checks and was abandoned after 706 days.
80%
#778 chore: pydantic 2 related cleanup craft-parts merged Merged a Pydantic 2 compatibility cleanup. Approved by two reviewers and passed CI. Modified seven files with 28 additions and 26 deletions. Required PR #775.
79%
#672 merge feature/pydantic-2 rockcraft merged Merged the pydantic 2 migration branch via rebase after two approvals and passing CI. The update modified 26 files, adding 3661 lines and removing 2150, finalizing the migration and dependency updates.
79%