← Back to issue list

fix(reactive): don't overwrite actions.yaml for reactive charms

View original Github issue

Metadata

Project
charmcraft
Number
#1829
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1829 as commit 4a3cbacb, fixing #1816 by preserving reactive charms' existing actions.yaml instead of overwriting it.

Resolution: closed resolved

Reason: The approved PR was merged as commit 4a3cbacb. It changed reactive builds to retain the existing actions.yaml, resolving the included-layer metadata problem reported in #1816.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #1816 CRAFT-3247

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1829 as commit 4a3cbacb, fixing #1816 by preserving reactive charms' existing actions.yaml instead of overwriting it.
stealth/space-bunny-alpha — closed resolved Merged #1829 as commit 4a3cbacb, preventing reactive builds from overwriting actions.yaml and fixing the included-layer metadata problem reported in #1816.
stealth/space-bunny-alpha — closed resolved Merged #1829 as 4a3cbacb, preventing actions.yaml from being overwritten for reactive charms and fixing #1816.
qwen/qwen3.6-35b-a3b — — Merged to fix issue #1816 by preventing the overwriting of actions.yaml for reactive charms. Approved by two reviewers, the change updates two files (+29/-5 lines) and resolves CRAFT-3247.
qwen3.6-35b-a3b-mtp-q6 — — Merged to resolve issue #1816 and CRAFT-3247. The change prevents overwriting actions.yaml in reactive charms, authored by maintainer lengau and successfully integrated.

Update history

No update history recorded yet.

Related work

  • Caused By: charmcraft#1816 (confidence 100%)

    The reactive metadata-loss bug prompted this fix, which the PR explicitly identifies as resolving.

Related issues

Issue Project State Summary Similarity
#2245 fix(reactive): don't overwrite config.yaml from a reactive charm charmcraft merged Merged PR #2245 (commit aa28f0dc, CRAFT-4206) stops the package service from overwriting a config.yaml generated by a reactive charm, fixing #2194.
80%
#1666 fix: only keep metadata.yaml for reactive charms charmcraft merged Merged #1666 (b2b127e6), retaining metadata.yaml only for reactive charms so non-reactive repacks no longer carry stale integration metadata; fixes #1654.
73%
#1114 config: support use actions in charmcraft.yaml charmcraft merged Merged #1114 as commit 201b40f6, enabling actions in charmcraft.yaml and refactoring configuration models to avoid circular imports.
70%