← Back to issue list

fix(reactive): don't overwrite actions.yaml for reactive charms

View original Github issue

Metadata

Project
charmcraft
Number
#1829
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged to fix issue #1816 by preventing the overwriting of actions.yaml for reactive charms. Approved by two reviewers, the change updates two files (+29/-5 lines) and resolves CRAFT-3247.

Suggested action:

No scores available.

Issue body

Fixes #1816 CRAFT-3247

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to fix issue #1816 by preventing the overwriting of actions.yaml for reactive charms. Approved by two reviewers, the change updates two files (+29/-5 lines) and resolves CRAFT-3247.
qwen3.6-35b-a3b-mtp-q6 Merged to resolve issue #1816 and CRAFT-3247. The change prevents overwriting actions.yaml in reactive charms, authored by maintainer lengau and successfully integrated.
qwen3.6-35b-a3b-mtp-q6 Merged a fix that prevents overwriting actions.yaml for reactive charms, resolving issue #1816 and CRAFT-3247.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2245 fix(reactive): don't overwrite config.yaml from a reactive charm charmcraft merged Merged following approval by three reviewers. Resolves issue #2194 and CRAFT-4206 by preventing reactive charms from overwriting config.yaml. Changes affect three files with minor code adjustments.
87%
#1666 fix: only keep metadata.yaml for reactive charms charmcraft merged Merged to fix issue #1654 by restricting metadata.yaml retention to reactive charms only. Approved by two reviewers, passed CI, and modified six files (+101/-5).
76%
#1114 config: support use actions in charmcraft.yaml charmcraft merged Merged update allowing actions in charmcraft.yaml instead of separate actions.yaml. Includes refactoring to fix circular imports. Approved by one reviewer across 10 files with 345 additions and 3 deletions.
75%
#142 fix the action generated by 'charmcraft init' charmcraft merged Merged a fix for the action generated by charmcraft init, resolving issue #141. Approved by three reviewers and verified by the reporter. Corrects a generation bug in the init command.
71%
#1524 fix(package): don't write a metadata.yaml if it already exists. charmcraft merged Merged a fix preventing overwrites of existing metadata.yaml files. Approved by two reviewers, this change enables reactive charm support in destructive mode as a partial resolution for issue #1488.
70%
#1615 feat: add config and actions processing to _extra_yaml_transform charmcraft merged Merged after two approvals. Adds config and actions processing to _extra_yaml_transform, resolving #1587. Changes span 19 files (+498/-29). A reviewer queried reactive charm compatibility, but the update was integrated.
70%