← Back to issue list

[EXPERIMENTAL]: poetry plugin

View original Github issue

Metadata

Project
charmcraft
Number
#1840
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Experimental Poetry plugin PR closed unmerged in favour of charmcraft#1899, merged as commit 8b748f3e, adding charmcraft/parts/plugins/_poetry.py and _python.py with charm-oriented defaults.

Resolution: closed superseded

Reason: The PR was never merged; maintainer lengau commented 'Implemented in #1899' and closed it. PR #1899 ('feat: add Python and Poetry plugins') was merged into main as commit 8b748f3e, landing charmcraft/parts/plugins/_poetry.py and _python.py registered in charmcraft/parts/__init__.py.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Experimental Poetry plugin PR closed unmerged in favour of charmcraft#1899, merged as commit 8b748f3e, adding charmcraft/parts/plugins/_poetry.py and _python.py with charm-oriented defaults.
stealth/space-bunny-alpha — closed superseded Experimental Poetry plugin was closed in favor of merged PR #1899 (8b748f3e), which added Charmcraft-specific Python and Poetry plugins.
qwen/qwen3.6-35b-a3b — — Superseded by pull request #1899, which implemented the experimental poetry plugin. The original PR was closed without merging.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by pull request #1899, which implemented the experimental poetry plugin. The original PR was closed by the maintainer after the feature was successfully integrated elsewhere.

Update history

No update history recorded yet.

Related work

  • Superseded By: charmcraft#1899 (confidence 98%)

    Merged as 8b748f3e; the closing comment on #1840 explicitly points to it as the implementation of the experimental plugin work.

  • Likely Fixed By: charmcraft#1940 (confidence 72%)

    Follow-up commit 408650c8 added docs for the python and poetry plugins delivered by #1899.

  • Related To: charmcraft#1967 (confidence 70%)

    Commit ff00a899 added howto guides for migrating from the charm plugin to the poetry plugin.

  • Related To: charmcraft#2022 (confidence 45%)

    Commit f993f242 updated craft-parts dependency, which the poetry plugin subclasses via craft_parts.plugins.poetry_plugin.

Related issues

Issue Project State Summary Similarity
#18 Poetry integration charmcraft closed Poetry support was ultimately delivered as Charmcraft-specific python/poetry craft-parts plugins, added in PR #1899 (commit 8b748f3e, 2023), superseding the older build.py requirements.txt idea; issue closed once shipped.
81%
#1873 Create charmcraft-specific versions of the upstream `python` and `poetry` plugins charmcraft closed Charmcraft-specific Python and Poetry plugins were added by merged PR #1899 (commit 8b748f3e), replacing the experimental work in #1840.
81%
#1899 feat: add Python and Poetry plugins charmcraft merged Merged into main via commit 8b748f3e, adding Charmcraft-specific Python and Poetry plugins with charm-oriented venv, pip, source-copy, and binary defaults.
80%
#1843 Add charmcraft-specific versions of upstream python plugins charmcraft open Request to add charmcraft-specific python/poetry plugins. Implemented by commit 8b748f3e (PR #1899) alongside #1873; the plugins are registered as 'python'/'poetry' in get_app_plugins() and have received later fixes (#1968, #2044, #2835).
79%
#818 [experimental] poetry plugin craft-parts closed Closed unmerged by maintainer lengau on 2024-08-23 as superseded by #820, which landed the Poetry plugin via commit 8b0d76c8 (feat(plugin): add poetry plugin).
77%
#2025 Poetry plugin: use parameters rather than env vars charmcraft closed Implemented parameter-based Poetry pip options in charmcraft#2044 (commit 0db15c18); the issue was later closed without a maintainer explanation.
76%
#820 feat(plugin): add poetry plugin craft-parts merged Merged Poetry plugin support in commit 8b0d76c8, adding first-class build-system handling via poetry install and resolving #707.
74%
#2026 Change poetry plugin keep bins default to True charmcraft closed Superseded by charmcraft#2036, merged as craft-parts commit 7fa20644; Python and Poetry charms now always retain a portable venv/bin/activate without Python binaries.
74%
#707 `poetry` Python plugin craft-parts closed Poetry plugin feature request implemented: PR #820 ("feat(plugin): add poetry plugin", commit 8b0d76c8) merged, later documented in #830 and fixed in #960. Issue closed by mr-cal on 2025-07-09 with "Completed via #820".
73%
#940 feat(plugins/poetry): add poetry and pip extra args craft-parts merged Merged into main as commit e55d6bcd. PR #940 added poetry-export-extra-args and poetry-pip-extra-args properties to the Poetry plugin for advanced users, with docs and unit tests.
73%