Change poetry plugin keep bins default to True
Metadata
Current evaluation
Superseded by charmcraft#2036, merged as craft-parts commit 7fa20644; Python and Poetry charms now always retain a portable venv/bin/activate without Python binaries.
Resolution: closed superseded
Reason: The author explicitly closed the change in favor of charmcraft#2036 after testing confirmed that Python binaries were not included. PR #2036 merged as craft-parts commit 7fa20644 and implemented portable bin/activate retention.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Including `bin/activate` in the virtual environment by default will make debugging much easier (charm developers can easily run Python code using the charm's virtual environment to debug issues)
@lengau to confirm, this won't have negative side effects of including a symlink to the python binary or copying the python binary itself into the *.charm artifact?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Superseded by charmcraft#2036, merged as craft-parts commit 7fa20644; Python and Poetry charms now always retain a portable venv/bin/activate without Python binaries. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed in favor of canonical/charmcraft#2036, which was merged into craft-parts and always retains a portable venv/bin/activate for Python and Poetry charms. | |
| qwen/qwen3.6-35b-a3b | — | — | Changes to the poetry plugin keep bins default were tested and confirmed safe. The author closed the request in favor of pull request #2036, which supersedes it. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by #2036. The change to default poetry plugin keep bins to True was closed after testing confirmed bin/activate inclusion does not copy the python binary into the charm artifact. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
charmcraft#2036
(confidence 100%)
The author directly identified #2036 as the replacement; it merged the completed implementation via craft-parts commit 7fa20644.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1899 feat: add Python and Poetry plugins | charmcraft | merged | Merged into main via commit 8b748f3e, adding Charmcraft-specific Python and Poetry plugins with charm-oriented venv, pip, source-copy, and binary defaults. | |
| #1840 [EXPERIMENTAL]: poetry plugin | charmcraft | closed | Experimental Poetry plugin PR closed unmerged in favour of charmcraft#1899, merged as commit 8b748f3e, adding charmcraft/parts/plugins/_poetry.py and _python.py with charm-oriented defaults. | |
| #2036 Fix & always include bin/activate in python & poetry plugin | charmcraft | merged | Merged PR #2036; commit 7fa20644 makes Python and Poetry plugins always retain bin/activate and replace its hard-coded VIRTUAL_ENV path with a portable path. | |
| #18 Poetry integration | charmcraft | closed | Poetry support was ultimately delivered as Charmcraft-specific python/poetry craft-parts plugins, added in PR #1899 (commit 8b748f3e, 2023), superseding the older build.py requirements.txt idea; issue closed once shipped. | |
| #1873 Create charmcraft-specific versions of the upstream `python` and `poetry` plugins | charmcraft | closed | Charmcraft-specific Python and Poetry plugins were added by merged PR #1899 (commit 8b748f3e), replacing the experimental work in #1840. | |
| #2025 Poetry plugin: use parameters rather than env vars | charmcraft | closed | Implemented parameter-based Poetry pip options in charmcraft#2044 (commit 0db15c18); the issue was later closed without a maintainer explanation. | |
| #2044 fix(plugins/poetry): set --no-binary=:all: by param | charmcraft | merged | Merged charmcraft PR #2044 to pass Poetry's --no-binary=:all: as a parameter, making pip option ordering deterministic; fixes #2025 and relies on craft-parts PR #940. |