refactor: use craft-platforms for build plans
Metadata
Current evaluation
Merged PR #1894 (commit f1755e8f, +25/-33) replaced Charmcraft's custom build-plan generation for `platforms` charms with craft-platforms, routing exhaustive build plans through craft-application's BuildPlanService.
Resolution: closed resolved
Reason: The PR itself was merged into main as commit f1755e8f by maintainer lengau, with two approvals. Charmcraft's CharmBuildPlanService now delegates to craft_platforms/craft-application build planning instead of its own logic.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Only applies to `platforms` charms.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1894 (commit f1755e8f, +25/-33) replaced Charmcraft's custom build-plan generation for `platforms` charms with craft-platforms, routing exhaustive build plans through craft-application's BuildPlanService. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1894, replacing Charmcraft’s custom build-plan logic for platforms charms with craft-platforms. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor replacing custom build plan logic with craft-platforms for platforms charms. Approved by two reviewers, the change modifies two files with a net reduction of eight lines, streamlining platform handling. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor that switches build plan generation to craft-platforms, scoped exclusively to platforms charms. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1876 Use craft-platforms for build plans | charmcraft | closed | Closed as done: charmcraft PR #1894 (commit f1755e8f) switched build plan generation to craft-platforms via craft-application's BuildPlanService; rockcraft did the same in #715. | |
| #391 Use craft-platforms for build plans | craft-application | closed | Build planning and filtering moved to craft-platforms in merged PR #25 (d9ff004); craft-application adopted the planner through merged PR #666 (621d1a32). | |
| #698 Use craft-platforms for build plans | rockcraft | closed | Merged PR #715 (516d29e5) replaced Rockcraft's custom build-plan generation with craft-platforms, resolving #698 and aligning plans with downstream consumers. | |
| #4 feat: add charmcraft build plans | craft-platforms | merged | Merged charmcraft build-plan support and supporting build-plan utilities in canonical/craft-platforms#4 via commit efa325b. | |
| #5015 Use craft-platforms for build plans | snapcraft | closed | Snapcraft adopted craft-platforms build plans in merged PR #5111 (commit 7969ee8d5), replacing its custom planning logic. | |
| #715 refactor: use craft-platform for the build plans | rockcraft | merged | Merged PR #715 (516d29e5) replaced Rockcraft’s custom build-plan generation with craft-platform, creating one shared source for Rockcraft and remote builds; fixes #698. | |
| #81 feat: multi-base support for charm build plans | craft-platforms | merged | Merged PR #81 as commit 519b705, adding multi-base charm build-plan support and fixing #73, with stricter shorthand validation and CraftPlatformsError. | |
| #5111 feat: use `craft-platforms` for build plans | snapcraft | merged | Merged in #5111 via commit 7969ee8d5, replacing Snapcraft’s custom build-plan logic with craft-platforms utilities. | |
| #1535 Implement platforms for charmcraft | charmcraft | closed | Implemented ST105-style platforms for charm builds in merged PR #1554, commit e3de0a46, completing the requested platform support. | |
| #837 create_build_plan: refactor | charmcraft | merged | Merged PR #837 (commit 974a1bc1, merge bec5c7c4, CRAFT-1272): moved create_build_plan to new charmcraft/providers/providers.py, made it return named tuples, and added direct unit tests. |