refactor: use craft-platforms for build plans
Metadata
Current evaluation
Merged a refactor replacing custom build plan logic with craft-platforms for platforms charms. Approved by two reviewers, the change modifies two files with a net reduction of eight lines, streamlining platform handling.
Suggested action: —
No scores available.
Issue body
Only applies to `platforms` charms.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor replacing custom build plan logic with craft-platforms for platforms charms. Approved by two reviewers, the change modifies two files with a net reduction of eight lines, streamlining platform handling. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor that switches build plan generation to craft-platforms, scoped exclusively to platforms charms. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor replacing build plan logic with craft-platforms, scoped to platforms charms. The change streamlines platform handling and was approved without comments. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5111 feat: use `craft-platforms` for build plans | snapcraft | merged | Merged the change to replace existing build plan logic with the craft-platforms library. Approved by two reviewers, the update modifies six files with a net reduction of 17 lines, streamlining platform detection and build configuration. | |
| #715 refactor: use craft-platform for the build plans | rockcraft | merged | Merged refactor to use craft-platform for build plans, creating a single source for Rockcraft and remote builds. Approved by two reviewers, resolving issue #698 with 31 additions and 3 deletions across five files. | |
| #5205 refactor: use craft-platforms utilities | snapcraft | merged | Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files. | |
| #698 Use craft-platforms for build plans | rockcraft | closed | Closed and superseded by prototype PR #662, which implements craft-platforms for build plans to deduplicate logic and ensure consistency across projects. No explicit resolution or merge details are documented. | |
| #1876 Use craft-platforms for build plans | charmcraft | closed | Closed without resolution. The proposal to use craft-platforms for build plans to deduplicate logic and ensure consistency was not implemented or superseded. | |
| #326 feat: add Platform model and default BuildPlanner | craft-application | merged | Merged after two approvals. Adds a Platform model and default BuildPlanner. The maintainer coordinated timing with related remote-build PRs to bundle fixes in a craft-application hotfix. | |
| #362 feat: support platforms for the build plans | rockcraft | merged | Merged feature adding platform support for build plans. Approved by two reviewers, the change modifies eight files (+39/-32 lines) and integrates the functionality. | |
| #4650 Refactor `platform` validation | snapcraft | closed | Platform validation refactoring completed. The build planner was restructured with craft-application 5 and craft-platforms, rendering the original scope obsolete. Validation logic was consolidated and cleaned up. | |
| #521 refactor: port code to latest craft-app update | rockcraft | merged | Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines). | |
| #639 Move the build planner logic into craft-platforms | rockcraft | open | Refactor to move build planner logic into craft-platforms, requested by jugmac00. Work completed: craft-application#391 closed as resolved, rockcraft PR #715 and commit 5f898b32 implemented the change. No BuildPlanner class remains in codebase. |