← Back to issue list

fix(plugins/poetry): set --no-binary=:all: by param

View original Github issue

Metadata

Project
charmcraft
Number
#2044
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged charmcraft PR #2044 to pass Poetry's --no-binary=:all: as a parameter, making pip option ordering deterministic; fixes #2025 and relies on craft-parts PR #940.

Resolution: closed resolved

Reason: PR #2044 was merged after approval. It resolves #2025 by replacing nondeterministic environment-variable configuration with parameters, using the API added by merged craft-parts PR #940 (commit e55d6bcd).

Evaluated by: mr-cal-bot

No scores available.

Issue body

This moves the environment variable configuration to use a parameter. This is needed because pip does not load environment variables in a deterministic order, but the order of these parameters matters. Requires https://github.com/canonical/craft-parts/pull/940 Fixes #2025 CRAFT-3794

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged charmcraft PR #2044 to pass Poetry's --no-binary=:all: as a parameter, making pip option ordering deterministic; fixes #2025 and relies on craft-parts PR #940.
stealth/space-bunny-alpha — closed resolved Merged CRAFT-3794 to configure Poetry with --no-binary=:all: as a parameter, avoiding nondeterministic pip environment ordering; fixes #2025 and depends on craft-parts#940.
qwen/qwen3.6-35b-a3b — — Merged fix replacing the --no-binary=:all: environment variable with a parameter to guarantee deterministic pip execution order. Approved by two reviewers, passed CI, and resolves #2025.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for the poetry plugin replacing an environment variable with a parameter for --no-binary=:all:. This ensures deterministic parameter ordering since pip loads environment variables unpredictably. Resolves #2025 and depends on craft-parts PR #940.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#2025 (confidence 100%)

    PR #2044 explicitly states that it fixes this Poetry plugin issue.

  • Related To: canonical/craft-parts#940 (confidence 100%)

    Required the merged Poetry and pip extra-arguments support used by charmcraft PR #2044.

Related issues

Issue Project State Summary Similarity
#2025 Poetry plugin: use parameters rather than env vars charmcraft closed Implemented parameter-based Poetry pip options in charmcraft#2044 (commit 0db15c18); the issue was later closed without a maintainer explanation.
73%
#2026 Change poetry plugin keep bins default to True charmcraft closed Superseded by charmcraft#2036, merged as craft-parts commit 7fa20644; Python and Poetry charms now always retain a portable venv/bin/activate without Python binaries.
71%