← Back to issue list

style: fix linting issues with ruff 0.12

View original Github issue

Metadata

Project
craft-application
Number
#803
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804.

Resolution: closed resolved

Reason: PR #803 was merged as commit 5e15ff09 after lint and fast-test checks passed. The separate fetch-service test failure was addressed by merged PR #804.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Test failure is fixed in #804

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-application#803 via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. Linting and fast tests passed; a separate test failure was fixed in #804.
qwen/qwen3.6-35b-a3b — — Merged after approval by two reviewers. Resolves linting failures introduced by ruff 0.12 across 14 files. CI passed for fast tests, linting, and security scans, while slow test failures were tracked separately in #804.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#804 (confidence 100%)

    Merged as bbaf03c7 to fix the fetch-service integration-test failure identified during #803.

Related issues

Issue Project State Summary Similarity
#173 style: fix lint for ruff 0.12 craft-archives merged Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed.
92%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed.
90%
#357 style: fix lints from ruff 0.12 craft-cli merged Merged as dd635c9, fixing new Ruff 0.12 lint errors across seven files (+11/-10); all CI checks passed.
90%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
89%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged #1465 as a58695ef, fixing five files (+13/-6) for compatibility with newer Ruff; all CI checks passed.
89%
#969 style: fix linting issues for ruff 0.9 craft-parts merged Merged as commit f1427855: small Ruff 0.9 lint fixes (+2/-1) across 2 files, following the ruff-pre-commit hook bump to the 0.9.x series.
88%
#19 style: fix linting issues for ruff 0.12 craft-artifacts closed PR #19 was closed unmerged after prolonged inactivity; its Ruff 0.12 lint fixes were abandoned. Later PR #20 was merged as commit 04cbdc0.
88%
#408 style: fix linting for ruff 0.12 starbase merged Merged PR #408 as commit dc41fe4, applying a one-line style change that restored linting compatibility with Ruff 0.12.
88%
#423 style(lint): fix ruff 0.6.0 linting errors craft-application merged Merged PR #423 as commit 2f56f14b, applying ruff check --fix across 21 files (+70/-70) to clear the new Ruff 0.6.0 lint errors. Approved by 2 maintainer reviewers.
87%
#1825 style(lint): fix ruff 0.6.0 linting errors charmcraft merged Merged PR #1825 as commit 7aa2965b, applying Ruff 0.6.0 autofixes across 31 files to resolve linting errors.
87%