feat: merge the 'static' tox environment into the 'lint' one
Metadata
Current evaluation
Merged the static tox environment into the lint environment to integrate pyright type checking into the lint command for machine and kubernetes init profiles. Approved by four reviewers.
Suggested action: —
No scores available.
Issue body
[OP061](https://docs.google.com/document/d/1GfOTT1Ir-pLAbILUrI4GS9T8AAI8Ni8gpF1Mh67Wx3E/edit?tab=t.0) has been approved and specifies that the `lint` command should also do static checking (such as type checking with pyright).
This PR makes that adjustment for the `machine` and `kubernetes` init profiles.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged the static tox environment into the lint environment to integrate pyright type checking into the lint command for machine and kubernetes init profiles. Approved by four reviewers. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged the 'static' tox environment into the 'lint' environment for machine and kubernetes init profiles. This implements approved OP061 requirements to include static type checking with pyright during linting. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged the 'static' tox environment into the 'lint' environment for machine and kubernetes init profiles, implementing OP061 to include static type checking with pyright in the lint command. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1137 Add "tox -e static" for static type checking (Pyright) | charmcraft | merged | Added a tox environment for Pyright static type checking. Merged after approval and passing CI checks. Updated ops version pinning to >=2.4.1 and adjusted code for type checker compatibility. | |
| #4820 fix(tox): use requirements-devel for linters | snapcraft | merged | Merged a pull request updating the tox configuration to use requirements-devel for linters. Approved by two reviewers and passing CI, the change modifies one file to resolve linting dependencies. | |
| #67 lint: fix ruff linting in tox | craft-archives | merged | Merged after reviewer approval and passing CI. Resolves ruff linting issues in the tox environment by updating three files. Code coverage remains unchanged at 88.07%. | |
| #4073 lint: reintroduce pylint in tox | snapcraft | merged | Merged into main following approval and passing CI checks. The change reintroduces pylint to the tox configuration, adding 15 lines and removing 1 in a single file. Code coverage remains unchanged. | |
| #66 tools: fix ruff linting command in tox | starbase | merged | Merged a one-line fix that corrected the ruff linting command in tox. The change received reviewer approval and was successfully integrated into the codebase. | |
| #576 build: fix tox test environments | craft-parts | merged | Merged a one-file change fixing tox test environments in the build configuration. Approved by two reviewers with zero unresolved comments. The update adjusted three lines to resolve environment setup issues. |