← Back to issue list

test: add regression tests for resolved issues #2361 and #2598

View original Github issue

Metadata

Project
charmcraft
Number
#2690
Type
pull request
State
closed
Author
Copilot
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged as redundant: #2681 already fixed #2598, while the accepted #2361 regression test was later merged via #2735 (8ef26978).

Resolution: closed superseded

Reason: A maintainer identified duplication with #2681, which fixed the remote-build failure. The remaining #2361 regression coverage was subsequently merged in #2735 via commit 8ef26978.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Research open issues to find ones resolved in current codebase - [x] Issue #2361 (mixing -p and -o flags): Fixed by PRs #2427 and #2600 in main; add regression test proving same project_dir and output_dir works without error - [x] Issue #2598 (remote-build fails with AttributeError on .name): Fixed in hotfix/4.2 (PR #2681) but not yet in main; port fix + add regression test - [x] Run all unit tests (219 pass) - [x] Run parallel validation (CodeQL: 0 alerts, code review addressed)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged as redundant: #2681 already fixed #2598, while the accepted #2361 regression test was later merged via #2735 (8ef26978).
stealth/space-bunny-alpha — closed superseded Closed unmerged after a maintainer flagged duplication with #2681; the accepted #2361 regression test was later merged in #2735 (8ef26978).
qwen/qwen3.6-35b-a3b — — Closed without merging. The PR added regression tests for issues #2361 and #2598, but reviewers noted the changes duplicated existing fixes from PR #2681. The branch was likely created incorrectly, resulting in abandonment.
qwen/qwen3.6-35b-a3b — — Closed without merging. A reviewer noted the PR duplicated work from PR #2681 and questioned the branch origin. The regression tests for issues #2361 and #2598 were abandoned as the fixes and tests already existed.
qwen/qwen3.6-35b-a3b — — Closed without merging. The PR added regression tests for issues #2361 and #2598 but was abandoned after a reviewer noted it duplicated fixes already merged in PR #2681. Issue #2361 was already resolved in main, and #2598 was addressed in a separate hotfix branch.
qwen/qwen3.6-35b-a3b — — Closed without merging. Reviewers noted the PR duplicates fixes and tests already merged in PR #2681, likely due to an incorrectly created branch. The contribution was superseded by existing work.
qwen/qwen3.6-35b-a3b — — Closed without merging. The PR added regression tests for issues #2361 and #2598 but was abandoned after a reviewer noted the changes duplicated work already merged in PR #2681, questioning the branch origin.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. The pull request added regression tests for issues #2361 and #2598, but a maintainer noted the changes duplicated existing work in PR #2681 and questioned the branch origin, resulting in closure.

Update history

No update history recorded yet.

Related work

  • Duplicate Of: canonical/charmcraft#2681 (confidence 99%)

    The maintainer said this PR duplicated the remote-build fix and tests already under review in #2681.

  • Likely Fixed By: canonical/charmcraft#2735 (confidence 99%)

    Merged commit 8ef26978 added the retained regression test for identical project and output directories.

  • Related To: canonical/charmcraft#2361 (confidence 98%)

    The accepted part of this PR covered the mixed -p and -o directory failure.

  • Related To: canonical/charmcraft#2598 (confidence 98%)

    The duplicated portion covered the remote-build project-name AttributeError.

Related issues

Issue Project State Summary Similarity
#2735 test: add regression test for issue #2361 charmcraft merged Merged PR #2735 as commit 8ef26978, adding regression coverage so artifacts are not moved when project and output directories are identical.
70%