← Back to issue list

test: add regression test for issue #2361

View original Github issue

Metadata

Project
charmcraft
Number
#2735
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2735 as commit 8ef26978, adding regression coverage so artifacts are not moved when project and output directories are identical.

Resolution: closed resolved

Reason: PR #2735 merged into main with all CI checks passing. Commit 8ef26978 added the regression test for the behavior reported in #2361.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR adds a regression test for issue #2361, verifying that we do not move the artifact if the project directory equals the output directory.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2735 as commit 8ef26978, adding regression coverage so artifacts are not moved when project and output directories are identical.
stealth/space-bunny-alpha — closed resolved PR #2735 merged in commit 8ef26978, adding regression coverage to ensure artifacts are not moved when project and output directories are identical, guarding the fix for #2361.
stealth/space-bunny-alpha — closed resolved Merged PR #2735 (commit 8ef26978) added regression coverage ensuring Charmcraft does not move the artifact when the project and output directories are identical.
qwen/qwen3.6-35b-a3b — — Merged following approval and successful CI checks. Introduces a regression test for issue #2361 to verify artifacts remain in place when the project directory matches the output directory.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#2361 (confidence 100%)

    This PR adds regression coverage for the matching project/output directory behavior reported in issue #2361.

  • Likely Fixed By: canonical/charmcraft#2600 (confidence 95%)

    Merged PR #2600, commit 868da353, fixed the underlying project/output directory handling before #2735 added test coverage.

Related issues

Issue Project State Summary Similarity
#896 test: don't leave behind test files rockcraft merged Merged PR #896 in commit 2cfd9f44, moving OCI test files to a temporary directory so tests no longer leave artifacts in the project root.
72%
#2690 test: add regression tests for resolved issues #2361 and #2598 charmcraft closed Closed unmerged as redundant: #2681 already fixed #2598, while the accepted #2361 regression test was later merged via #2735 (8ef26978).
70%