fix(hotfix/2.7): bump protobuf to 4.25.8 for setuptools without pkg_resources
Metadata
Current evaluation
PR #2934 proposed bumping protobuf 3.20.3→4.25.8 to unblock source builds under setuptools 84, but was closed without a merge or recorded follow-up.
Resolution: closed stale
Reason: PR #2934 was closed with review still pending, no CI checks or comments, and no matching merge commit in Charmcraft history. With no maintainer explanation or superseding reference, the protobuf bump appears abandoned rather than resolved.
Evaluated by: mr-cal-bot
No scores available.
Issue body
## Summary
Stacked on #2933.
After the rustc bump in #2932, `snap-build` gets past `maturin` and fails on
`protobuf`:
```
ModuleNotFoundError: No module named 'pkg_resources'
ERROR: Failed to build 'protobuf' when getting requirements to build wheel
```
The snap builds everything from source (`PIP_NO_BINARY: ":all:"`), so pip also
creates protobuf's isolated build environment. protobuf 3.20.3's `setup.py`
imports `pkg_resources`, which setuptools removed in 81; current setuptools is
84, so the sdist cannot build. pip also ignores constraints files for
build-isolation, so the build environment cannot be pinned from the repo.
protobuf 3.20.3 -> 4.25.8 is API compatible: the 4.x line of that era is a
re-versioning of the 3.20 code, and `macaroonbakery` (the only consumer) just
requires `protobuf >=3.20.0`. Verified locally that the 4.25.8 sdist builds
fully on Python 3.10 with setuptools 84.
The pure-python `protobuf-3.20.3-py2.py3-none-any.whl` could be pulled in with
`PIP_ONLY_BINARY: protobuf` to keep the old version, but that ships the slower
pure-Python implementation to avoid a version bump, so it was rejected.
## Test plan
CI: `snap-build` completes the `charmcraft` part with `protobuf` compiled from
source, which unblocks `snap-tests`.
> [!WARNING]
> Generated by an automated agent, not a human.
🤖 **BEEP BOOP I'M A TOASTER**
_Model:_ `step-5-preview-free`
_Harness:_ opencode CLI
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| minimax/minimax-m3.1-flash:free | — | closed stale | PR #2934 proposed bumping protobuf 3.20.3→4.25.8 to unblock source builds under setuptools 84, but was closed without a merge or recorded follow-up. |
Update history
| Date | Change |
|---|---|
| closed | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
canonical/charmcraft#2933
(confidence 100%)
The PR body identifies #2933 as its stacked prerequisite.
-
Related To:
canonical/charmcraft#2932
(confidence 100%)
The rustc bump in #2932 exposed the protobuf source-build failure addressed by this PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2942 fix(hotfix/2.7): bump protobuf to 4.25.8 for setuptools without pkg_resources | charmcraft | closed | Protobuf 4.25.8 hotfix PR #2942 was closed unmerged after its stacked base PR #2941 merged; no protobuf version bump landed. | |
| #2938 fix(hotfix/2.7): bump protobuf to 4.25.8 for setuptools without pkg_resources | charmcraft | closed | Closed as superseded during a stack rebuild; #2938 carried the same protobuf 4.25.8 bump as #2934 and was replaced by a fresh PR with no content change. |