← Back to issue list

Tests improvements to minimize future merges from resources draft branch

View original Github issue

Metadata

Project
charmcraft
Number
#367
Type
pull request
State
merged
Author
facundobatista
Labels
Created
Updated
Closed

Current evaluation

Merged test-only improvements to streamline future merges from a draft branch. Changes simplify OCIRegistry calls, improve naming, add auth schema, and isolate a main test. No functionality affected. Approved by two reviewers and passed CI.

Suggested action:

No scores available.

Issue body

Some small changes, everything just in tests, no affected functionality: - simplified some OCIRegistry calls, the "test-orga" makes no more sense (left it as-is in other tests that will disappear in the future) - improved some test names - added schema to "service" key in auth tests, it's more real now - improved a test in test_main.py to isolate it from the running environment

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged test-only improvements to streamline future merges from a draft branch. Changes simplify OCIRegistry calls, improve naming, add auth schema, and isolate a main test. No functionality affected. Approved by two reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged test-only improvements to streamline future merges from a draft branch. Updates include simplified OCIRegistry calls, renamed tests, added auth schema, and isolated an environment-dependent test in test_main.py.
qwen3.6-35b-a3b-mtp-q6 Merged test-only updates to prevent future merge conflicts from a draft branch. Changes simplify OCIRegistry calls, rename tests, add auth service schemas, and isolate a test from the running environment.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1928 tests: remove duplicate tests snapcraft merged Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. Approved by two reviewers, passed CI, and reduced unit test execution time.
72%
#896 test: don't leave behind test files rockcraft merged Merged a fix preventing OCI tests from leaving residual files in the project root. The change redirects test output to a temporary directory. Approved by three reviewers with all CI checks passing.
71%