manifest: add bases support to create_manifest() (CRAFT-63)
Metadata
Current evaluation
Merged in canonical/charmcraft#384 via eef1e421: moved create_manifest() to a dedicated module and added optional run-on bases_config support; runtime activation remained future work.
Resolution: closed resolved
Reason: PR #384 was merged through merge commit c8d4fe97. Its implementation moved manifest creation into its own module and added tested bases configuration support.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- Move create_manifest() out of utils into its own module. This will
prevent a potential import loop due to dependencies on util in config.
- Add optional bases_config parameter to use the run-on bases
configuration.
Note that runtime usage still only invokes the "legacy" non-bases
configuration. Future work will enable the usage of bases and this
just adds test coverage for the future case.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/charmcraft#384 via eef1e421: moved create_manifest() to a dedicated module and added optional run-on bases_config support; runtime activation remained future work. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged: moved create_manifest() into a dedicated module and added optional run-on bases_config support; runtime use of bases remains future work. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and CI checks. Adds an optional bases_config parameter to create_manifest() and relocates it to a dedicated module to prevent import loops. Runtime retains legacy behavior while new tests prepare for future bases implementation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Relocated create_manifest() to a dedicated module to prevent import loops and added an optional bases_config parameter for future runtime usage. Includes test coverage for the new configuration path. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1795 fix(package): Limit the bases in manifest.yaml | charmcraft | merged | Merged #1795 in commit 8b16cae4, limiting manifest.yaml bases for bases charms to those used by the current build instead of all run bases. | |
| #411 build: pack charm in provided environment when using bases (CRAFT-313) | charmcraft | merged | Merged PR #411 (CRAFT-313) to pack each viable bases configuration in its provided build environment; merge commit 523c6fb0. | |
| #280 Added a helper to create a manifest | charmcraft | merged | Merged PR #280 in commit f13e7bbc, adding a reusable manifest-creation helper for upcoming charm and bundle builders. |