← Back to issue list

fix(package): Limit the bases in manifest.yaml

View original Github issue

Metadata

Project
charmcraft
Number
#1795
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1795 in commit 8b16cae4, limiting manifest.yaml bases for bases charms to those used by the current build instead of all run bases.

Resolution: closed resolved

Reason: PR #1795 was approved and merged. Commit 8b16cae4 fixes manifest generation to record only the bases selected for the current build.

Evaluated by: mr-cal-bot

No scores available.

Issue body

For a `bases` charm, this was previously writing out all run bases rather than the specific bases for this build.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1795 in commit 8b16cae4, limiting manifest.yaml bases for bases charms to those used by the current build instead of all run bases.
stealth/space-bunny-alpha — closed resolved Merged in charmcraft#1795 (commit 8b16cae4), fixing bases-charm manifest.yaml generation to list only the bases used by the current build rather than all run bases.
qwen/qwen3.6-35b-a3b — — Merged a fix correcting manifest.yaml generation for bases charms. The build previously output all run bases instead of only the specific bases for the current build. Approved by two reviewers, modified 8 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for manifest.yaml generation in bases charms. The change restricts output to only the specific bases for the current build, correcting a bug that previously wrote all run bases.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#479 The control of `bases` in `charmcraft.yaml` should be different for bundles charmcraft closed Fixed by merged PR #545: bundles no longer warn when bases is omitted, and bundle configurations declaring bases are rejected.
73%
#384 manifest: add bases support to create_manifest() (CRAFT-63) charmcraft merged Merged in canonical/charmcraft#384 via eef1e421: moved create_manifest() to a dedicated module and added optional run-on bases_config support; runtime activation remained future work.
72%
#411 build: pack charm in provided environment when using bases (CRAFT-313) charmcraft merged Merged PR #411 (CRAFT-313) to pack each viable bases configuration in its provided build environment; merge commit 523c6fb0.
71%
#383 commands/build: charm file name format support for bases (CRAFT-66) charmcraft merged Merged PR #383 (commit 951f6aaa; merge 1c839909) added bases-aware charm filename formatting and tests, retaining the legacy runtime path pending default-bases configuration.
70%