← Back to issue list

fix(package): Limit the bases in manifest.yaml

View original Github issue

Metadata

Project
charmcraft
Number
#1795
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a fix correcting manifest.yaml generation for bases charms. The build previously output all run bases instead of only the specific bases for the current build. Approved by two reviewers, modified 8 files.

Suggested action:

No scores available.

Issue body

For a `bases` charm, this was previously writing out all run bases rather than the specific bases for this build.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix correcting manifest.yaml generation for bases charms. The build previously output all run bases instead of only the specific bases for the current build. Approved by two reviewers, modified 8 files.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for manifest.yaml generation in bases charms. The change restricts output to only the specific bases for the current build, correcting a bug that previously wrote all run bases.
qwen3.6-35b-a3b-mtp-q6 Merged a fix that limits manifest.yaml to only include specific build bases for bases charms, replacing the previous behavior of incorrectly writing all run bases.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#390 build/pack: add support for bases in managed mode (CRAFT-131) charmcraft merged Merged changes adding bases support for managed mode in build/pack. Introduces a bases module, extends configuration validation with warnings, and updates run() to return built charms. Approved by two reviewers and merged.
74%
#411 build: pack charm in provided environment when using bases (CRAFT-313) charmcraft merged Merged implementation for packing charms in provided environments per bases configuration (CRAFT-313). Approved by two reviewers, modifying two files (+175/-30). Future work will add verbose and quiet mode flag support.
73%
#282 Have 'bases' in the manifest, with the translated architecture. charmcraft merged Added 'bases' to the manifest with translated architecture. Approved by two reviewers, the change modifies two files and was merged ahead of related work #281.
73%
#383 commands/build: charm file name format support for bases (CRAFT-66) charmcraft merged Merged following approval by three reviewers. Introduces charm file name format support for bases configuration, preserving the existing format as a legacy runtime path. Includes corresponding tests. (+98/-1 lines, 2 files changed)
73%