← Back to issue list

providers: add get_instance_name() for naming instances (CRAFT-310)

View original Github issue

Metadata

Project
charmcraft
Number
#407
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #407 added providers.get_instance_name() for launch instance naming in CRAFT-310 (commit 0cb02bf4; merge d9179bdf).

Resolution: closed resolved

Reason: PR #407 was approved and merged via d9179bdf, adding the requested helper in commit 0cb02bf4.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #407 added providers.get_instance_name() for launch instance naming in CRAFT-310 (commit 0cb02bf4; merge d9179bdf).
stealth/space-bunny-alpha — closed resolved Merged PR #407 (commit 0cb02bf4, merge d9179bdf): added providers.get_instance_name() to derive launch instance names for CRAFT-310; approved by 2 reviewers, 54 lines across 2 files.
stealth/space-bunny-alpha — closed resolved Merged the CRAFT-310 provider update, adding get_instance_name() for consistent instance naming; the change adds 54 lines across 2 files.
stealth/space-bunny-alpha — closed resolved Merged into main via PR #407, adding providers.get_instance_name() for instance naming.
qwen/qwen3.6-35b-a3b — — Merged addition of get_instance_name() for instance naming (CRAFT-310). Approved by two reviewers with zero unresolved comments. Introduces 54 lines across two files and was signed off by maintainer Chris Patterson.
qwen3.6-35b-a3b-mtp-q6 — — Merged without comments or revisions, adding get_instance_name() to providers for instance naming and resolving CRAFT-310.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#885 (confidence 95%)

    Later moved the get_instance_name functionality to a providers helper in commit 5fcdd221.

Related issues

Issue Project State Summary Similarity
#74 providers: move get_instance_name() to providers.py rockcraft merged Merged in canonical/rockcraft#74 (c5423c5a), moving Rockcraft-specific get_instance_name() into providers.py for CRAFT-1350.
75%
#885 (internal) Moved get_instance_name functionality to providers helper (CRAFT-1304). charmcraft merged Merged the CRAFT-1304 refactor in #885, moving get_instance_name functionality to the providers helper.
74%
#3926 providers: move `get_instance_name()` to providers.py snapcraft merged Merged as commit c1246cbe3 (+82/-45, 6 files): moved the snapcraft-specific get_instance_name() out of craft-providers into snapcraft/providers/providers.py (CRAFT-1305 prep for the new craft-providers API).
71%