providers: move get_instance_name() to providers.py
Metadata
Current evaluation
Merged in canonical/rockcraft#74 (c5423c5a), moving Rockcraft-specific get_instance_name() into providers.py for CRAFT-1350.
Resolution: closed resolved
Reason: The approved change was merged as commit c5423c5a, completing the relocation of get_instance_name() to providers.py.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
`get_instance_name()` is a rockcraft-specific function, so it is moved to providers.py
(CRAFT-1350)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/rockcraft#74 (c5423c5a), moving Rockcraft-specific get_instance_name() into providers.py for CRAFT-1350. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #74 as commit c5423c5a, moving Rockcraft-specific get_instance_name() into providers.py for CRAFT-1350. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/rockcraft#74, moving the Rockcraft-specific get_instance_name() function to providers.py as part of CRAFT-1350. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and passing CI. Moved the rockcraft-specific get_instance_name() function to providers.py, changing 8 files. Resolves CRAFT-1350. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged the refactoring that relocates the rockcraft-specific get_instance_name() function to providers.py, resolving CRAFT-1350. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/rockcraft#80
(confidence 98%)
Follow-up PR ca679971 moved the get_instance_name() call to lifecycle.py.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #80 providers: move `get_instance_name()` call to lifecycle.py | rockcraft | merged | Merged canonical/rockcraft#80 as ca679971, moving Rockcraft-specific get_instance_name() from Provider classes to lifecycle.py (CRAFT-1379). | |
| #3926 providers: move `get_instance_name()` to providers.py | snapcraft | merged | Merged as commit c1246cbe3 (+82/-45, 6 files): moved the snapcraft-specific get_instance_name() out of craft-providers into snapcraft/providers/providers.py (CRAFT-1305 prep for the new craft-providers API). | |
| #885 (internal) Moved get_instance_name functionality to providers helper (CRAFT-1304). | charmcraft | merged | Merged the CRAFT-1304 refactor in #885, moving get_instance_name functionality to the providers helper. | |
| #407 providers: add get_instance_name() for naming instances (CRAFT-310) | charmcraft | merged | Merged PR #407 added providers.get_instance_name() for launch instance naming in CRAFT-310 (commit 0cb02bf4; merge d9179bdf). | |
| #3940 providers: move `get_provider()` to providers.py | snapcraft | merged | Merged PR #3940 by mr-cal moved get_provider() into snapcraft/providers.py (squash commit 2acdd89b6), a CRAFT-1409 refactor mirroring canonical/rockcraft#92, part of a series of provider/lifecycle function moves. | |
| #110 providers: move lxd project name out of craft-providers interface | rockcraft | merged | Merged PR #110 (f72beac0), moving Rockcraft's LXD project name from lxd.py to providers.py and out of the craft-providers interface. | |
| #898 providers: move `get_provider()` to providers.py | charmcraft | merged | Merged charmcraft#898, moving get_provider() into providers.py for CRAFT-1410 after prerequisite charmcraft#896 landed. |